Skip to contentSkip to conversation

mpc52xx_pic: fix main interrupt masking

PATCH In review Domen Puncer 2 participants 2 messages Mar 6, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpc52xx_pic: fix main interrupt masking

Fix main interrupt masking.
Tested with RTC and GPIO_WKUP interrupts.

---
 arch/powerpc/platforms/52xx/mpc52xx_pic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/platforms/52xx/mpc52xx_pic.c +2 -2
Index: grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
===================================================================
@@ -128,7 +128,7 @@ static void mpc52xx_main_mask(unsigned i
 
 	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
 
-	io_be_setbit(&intr->main_mask, 15 - l2irq);
+	io_be_setbit(&intr->main_mask, 16 - l2irq);
 }
 
 static void mpc52xx_main_unmask(unsigned int virq)
@@ -141,7 +141,7 @@ static void mpc52xx_main_unmask(unsigned
 
 	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
 
-	io_be_clrbit(&intr->main_mask, 15 - l2irq);
+	io_be_clrbit(&intr->main_mask, 16 - l2irq);
 }
 
 static struct irq_chip mpc52xx_main_irqchip = {
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Domen Puncer

Fix main interrupt masking.
Tested with RTC and GPIO_WKUP interrupts.

Damn, I knew I forgot something during the last batch ! That bug had already been spotted earlier ...

Quoted 32 lines
---
 arch/powerpc/platforms/52xx/mpc52xx_pic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
===================================================================

arch/powerpc/platforms/52xx/mpc52xx_pic.c +2 -2
@@ -128,7 +128,7 @@ static void mpc52xx_main_mask(unsigned i
 
 	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
 
-	io_be_setbit(&intr->main_mask, 15 - l2irq);
+	io_be_setbit(&intr->main_mask, 16 - l2irq);
 }
 
 static void mpc52xx_main_unmask(unsigned int virq)
@@ -141,7 +141,7 @@ static void mpc52xx_main_unmask(unsigned
 
 	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
 
-	io_be_clrbit(&intr->main_mask, 15 - l2irq);
+	io_be_clrbit(&intr->main_mask, 16 - l2irq);
 }
 
 static struct irq_chip mpc52xx_main_irqchip = {

_______________________________________________
Linuxppc-embedded mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-embedded