Skip to contentSkip to conversation

Delays for crappy USB keys

PATCH New Rodolfo Giometti 2 participants 3 messages Mar 6, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Delays for crappy USB keys

Hello,

I noticed that using this patch:

common/usb.c +1 -1
index 0857494..087a65f 100644
@@ -61,7 +61,7 @@ #undef USB_DEBUG
 #ifdef USB_DEBUG
 #define        USB_PRINTF(fmt,args...) printf (fmt ,##args)
 #else
-#define USB_PRINTF(fmt,args...)
+#define USB_PRINTF(fmt,args...)        wait_ms(1) /* for crappy USB keys... */
 #endif
 

allows crappy USB keys to work well. :)

Ciao,

Rodolfo

Signature · 4 lines
GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127
#1 lore raw

PATCH 1/1 Delays for crappy USB keys

Quoted 8 lines · In message <[email protected]> you wrote:

I noticed that using this patch:

common/usb.c +0 -0
index 0857494..087a65f 100644

common/usb.c #undef USB_DEBUG · line 67

Quoted 8 lines
common/usb.c +1 -1
@@ -61,7 +61,7 @@ #undef USB_DEBUG
 #ifdef USB_DEBUG
 #define        USB_PRINTF(fmt,args...) printf (fmt ,##args)
 #else
-#define USB_PRINTF(fmt,args...)
+#define USB_PRINTF(fmt,args...)        wait_ms(1) /* for crappy USB keys... */
 #endif
 
 allows crappy USB keys to work well. :)

Ummm.. I guess I don't have to tell you that this is just a pretty dirty hack; can you please try to find out where exactly the delay should be added to the code?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A door is what a dog is perpetually on the wrong side of.
                                                        - Ogden Nash
#2 lore raw

PATCH 1/1 Delays for crappy USB keys

Quoted 16 lines · Wolfgang Denk
Quoted 15 lines · In message <[email protected]> you wrote:

I noticed that using this patch:

common/usb.c +1 -1
index 0857494..087a65f 100644
@@ -61,7 +61,7 @@ #undef USB_DEBUG
 #ifdef USB_DEBUG
 #define        USB_PRINTF(fmt,args...) printf (fmt ,##args)
 #else
-#define USB_PRINTF(fmt,args...)
+#define USB_PRINTF(fmt,args...)        wait_ms(1) /* for crappy USB keys... */
 #endif
 
Quoted 5 lines

common/usb.c #undef USB_DEBUG · line 67

Quoted 1 line
common/usb.c +0 -0
 allows crappy USB keys to work well. :)

Ummm.. I guess I don't have to tell you that this is just a pretty dirty hack; can you please try to find out where exactly the delay should be added to the code?

You are right but after putting some delays around the code I preferred to use this ??dirty hack! :)

However as soon as I have more free time I'll try to find out where exactly I should add the delay.

Ciao,

Rodolfo

Signature · 4 lines
GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127