Skip to contentSkip to conversation

udp: net-2.6.22 build fix

PATCH Applied Stephen Hemminger 3 participants 4 messages Mar 7, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 udp: net-2.6.22 build fix

Recent change broke build of UDP.

net/ipv4/udp.c +1 -1
@@ -1283,7 +1283,7 @@
 	 * the network is concerned, anyway) as per 4.1.3.4 (MUST).
 	 */
 	LIMIT_NETDEBUG(KERN_DEBUG "UDP%s: bad checksum. From %d.%d.%d.%d:%d to %d.%d.%d.%d:%d ulen %d\n",
-		       is_udplite? "-Lite" : "",
+		       proto == IPPROTO_UDPLITE ? "-Lite" : "",
 		       NIPQUAD(saddr),
 		       ntohs(uh->source),
 		       NIPQUAD(daddr),
#1 lore raw
Quoted 3 lines · Stephen Hemminger

Recent change broke build of UDP.

Thanks for that Stephen. Somehow this one got away. Perhaps we can recode these macros so that they always get compiled-checked?

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
maintainer
#2 lore raw

From: Herbert Xu <[email protected]>
Date: Thu, 8 Mar 2007 08:51:48 +1100

Quoted 2 lines

Perhaps we can recode these macros so that they always get compiled-checked?

Yes, we really should.