exportfs: move acceptable check into find_acceptable_alias (resend)
Subsystems (3)
PATCH 6/8 exportfs: move acceptable check into find_acceptable_alias (resend)
All callers of find_acceptable_alias check if the current dentry is acceptable before looking for other acceptable aliases using find_acceptable_alias. Move the check into find_acceptable_alias to make the code a little more dense and add a comment to find_acceptable_alias that documents it's intent.
fs/exportfs/expfs.c +6 -6
@@ -39,6 +39,9 @@return get_name (dir, name, child); } +/* +* Check if the dentry or any of it's aliases is acceptable. +*/ static struct dentry * find_acceptable_alias(struct dentry *result, int (*acceptable)(void *context, struct dentry *dentry),
@@ -46,6 +49,9 @@ {struct dentry *dentry, *toput =NULL ; +if (acceptable (context, result)) +return result; +spin_lock (&dcache_lock);list_for_each_entry (dentry, &result->d_inode->i_dentry, d_alias) {dget_locked (dentry);
@@ -128,9 +134,6 @@ target_dir =dget (result); }else { -if (acceptable (context, result)) -return result; - alias =find_acceptable_alias (result, acceptable, context);if (alias)return alias;
@@ -291,9 +294,6 @@ } }dput (target_dir); -/* now result is properly connected, it is our best bet */ -if (acceptable (context, result)) -return result; alias =find_acceptable_alias (result, acceptable, context);if (alias)
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs