Skip to contentSkip to conversation

swsusp: platform notifications not properly undone in case of error

DISCUSSION Pavel Machek 2 participants 2 messages Mar 8, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi!

Using IPI No-Shortcut mode
swsusp: Resume From Partition /dev/sda1
PM: Checking swsusp image.
swsusp: Signature found, resuming
PM: Preparing processes for restore. Stopping tasks ... done.
PM: Reading swsusp image.
Loading image data pages (125285 pages) ... <3>swsusp: Resume
mismatch: version
Read 501140 kbytes in 0.01 seconds (50114.00 MB/s)
swsusp: Error -1 resuming
PM: Restore failed, recovering.
Restarting tasks ... done.
PM: Resume from disk failed.
md: Autodetecting RAID arrays.

...and machine boots, but moon icon keeps blinking.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 19 lines · Pavel Machek

Hi!

Using IPI No-Shortcut mode
swsusp: Resume From Partition /dev/sda1
PM: Checking swsusp image.
swsusp: Signature found, resuming
PM: Preparing processes for restore. Stopping tasks ... done.
PM: Reading swsusp image.
Loading image data pages (125285 pages) ... <3>swsusp: Resume
mismatch: version
Read 501140 kbytes in 0.01 seconds (50114.00 MB/s)
swsusp: Error -1 resuming
PM: Restore failed, recovering.
Restarting tasks ... done.
PM: Resume from disk failed.
md: Autodetecting RAID arrays.

Quoted 1 line

...and machine boots, but moon icon keeps blinking.

Does the appended patch help?

Rafael

---
 kernel/power/disk.c |    1 +
 1 file changed, 1 insertion(+)
kernel/power/disk.c +1 -0
Index: linux-2.6.21-rc3/kernel/power/disk.c
===================================================================
@@ -261,6 +261,7 @@ static int software_resume(void)
 	error = swsusp_read();
 	if (error) {
 		swsusp_free();
+		platform_finish();
 		goto Thaw;
 	}