ide: always disable DMA before tuning it

PATCH In review Bartlomiej Zolnierkiewicz 1 participant 1 message Mar 10, 2007 libata

lore

Share & tools

lore

Bartlomiej Zolnierkiewicz

author

2007-03-10 21:09 UTC #0 lore raw

PATCH 5/13 ide: always disable DMA before tuning it

[PATCH] ide: always disable DMA before tuning it

ide_start_power_step() and set_using_dma() were missing ->dma_off_quietly call (comment in probe_hwif() states that DMA should be always cleared before tuning is attempted). Fix it.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---

 drivers/ide/ide-io.c |    1 +
 drivers/ide/ide.c    |    1 +
 2 files changed, 2 insertions(+)

drivers/ide/ide-io.c +1 -0

Index: b/drivers/ide/ide-io.c
===================================================================
@@ -223,6 +223,7 @@ static ide_startstop_t ide_start_power_s
 			break;
 		if (drive->hwif->ide_dma_check == NULL)
 			break;
+		drive->hwif->dma_off_quietly(drive);
 		ide_set_dma(drive);
 		break;
 	}

drivers/ide/ide.c +1 -0

Index: b/drivers/ide/ide.c
===================================================================
@@ -898,6 +898,7 @@ int set_using_dma(ide_drive_t *drive, in
 	if (HWIF(drive)->ide_dma_check == NULL)
 		return -EPERM;
 	if (arg) {
+		HWIF(drive)->dma_off_quietly(drive);
 		if (ide_set_dma(drive))
 			return -EIO;
 		if (HWIF(drive)->ide_dma_on(drive)) return -EIO;