Skip to contentSkip to conversation

i386: Fix GDT's number of quadwords in

PATCH In review Ahmed S. Darwish 3 participants 3 messages Mar 7, 2007 – Mar 11, 2007 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386: Fix GDT's number of quadwords in

Hi list,

Fix comments to represent the true number of quadwords in GDT.

---

arch/i386/kernel/head.S +2 -2
index 3fa7f93..cb185f4 100644
@@ -612,7 +612,7 @@ ENTRY(boot_gdt_table)
 	.quad 0x00cf92000000ffff	/* kernel 4GB data at 0x00000000 */
 
 /*
- * The Global Descriptor Table contains 28 quadwords, per-CPU.
+ * The Global Descriptor Table contains 32 quadwords, per-CPU.
  */
 	.align L1_CACHE_BYTES
 ENTRY(cpu_gdt_table)
@@ -639,7 +639,7 @@ ENTRY(cpu_gdt_table)
 
 	/*
 	 * Segments used for calling PnP BIOS have byte granularity.
-	 * They code segments and data segments have fixed 64k limits,
+	 * The code segments and data segments have fixed 64k limits,
 	 * the transfer segment sizes are set at run time.
 	 */
 	.quad 0x00409a000000ffff	/* 0x90 32-bit code */
Signature · 7 lines
Ahmed S. Darwish
http://darwish.07.googlepages.com

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
#1 lore raw

PATCH 1/1 i386: Fix GDT's number of quadwords in

Hi list,

Fix comments to represent the true number of quadwords in GDT.

---

arch/i386/kernel/head.S +2 -2
index 3fa7f93..cb185f4 100644
@@ -612,7 +612,7 @@ ENTRY(boot_gdt_table)
 	.quad 0x00cf92000000ffff	/* kernel 4GB data at 0x00000000 */
 
 /*
- * The Global Descriptor Table contains 28 quadwords, per-CPU.
+ * The Global Descriptor Table contains 32 quadwords, per-CPU.
  */
 	.align L1_CACHE_BYTES
 ENTRY(cpu_gdt_table)
@@ -639,7 +639,7 @@ ENTRY(cpu_gdt_table)
 
 	/*
 	 * Segments used for calling PnP BIOS have byte granularity.
-	 * They code segments and data segments have fixed 64k limits,
+	 * The code segments and data segments have fixed 64k limits,
 	 * the transfer segment sizes are set at run time.
 	 */
 	.quad 0x00409a000000ffff	/* 0x90 32-bit code */
Signature · 15 lines
Ahmed S. Darwish
http://darwish.07.googlepages.com

Acked-by: Randy Dunlap <[email protected]>

cc: to Andrew for merging.  Is this method OK with you for KJ patches
or would you prefer to see a KJ patchset maintained (again)?

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
#2 lore raw
In reply to Ahmed S. Darwish
Quoted 8 lines · On Wed, 7 Mar 2007 16:07:49 -0800 Randy Dunlap <[email protected]> wrote:

Hi list,

Fix comments to represent the true number of quadwords in GDT.

---

This should have been

From: Ahmed

<changelog>

Signed-off-by Ahmed
Signed-off-by Randy
Quoted 2 lines

cc: to Andrew for merging. Is this method OK with you for KJ patches or would you prefer to see a KJ patchset maintained (again)?

I'm easy. But please be aware that I prefer not to do spello and grammaro fixes, unless they're in something user-visible: a printk or documentation. Simply because there would be no end to it.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors