Skip to contentSkip to conversation

zd1211rw: sparse-annotate radiotap header

PATCH In review Pavel Roskin 2 participants 2 messages Mar 11, 2007 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zd1211rw: sparse-annotate radiotap header

All fields in radiotap header must be little endian. The driver does it correctly, but the structure definition must be annotated.

---

 drivers/net/wireless/mac80211/zd1211rw/zd_mac.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/mac80211/zd1211rw/zd_mac.c +2 -2
index 5b9e04a..231ec2d 100644
@@ -367,8 +367,8 @@ struct zd_rt_hdr {
 	struct ieee80211_radiotap_header rt_hdr;
 	u8  rt_flags;
 	u8  rt_rate;
-	u16 rt_channel;
-	u16 rt_chbitmask;
+	__le16 rt_channel;
+	__le16 rt_chbitmask;
 } __attribute__((packed));
 
 static void fill_rt_header(void *buffer, struct zd_mac *mac,
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · On 07-03-10 23:40 Pavel Roskin wrote:

All fields in radiotap header must be little endian. The driver does it correctly, but the structure definition must be annotated.

I have put the patch in the zd1211rw branch of my wireless-dev git tree, which can be found under

http://www.deine-taler.de/zd1211/wireless-dev.git/

Cheers,

Uli

Signature · 1 line
Uli Kunitz