w83627hf: Convert to a platform driver
PATCH 1/1 w83627hf: Convert to a platform driver
Convert the w83627hf driver from the nonsensical i2c-isa hack to a regular platform driver.
--- drivers/hwmon/Kconfig | 3 - drivers/hwmon/w83627hf.c | 591 ++++++++++++++++++++++++---------------------- 2 files changed, 311 insertions(+), 283 deletions(-)
drivers/hwmon/Kconfig +1 -2
@@ -549,8 +549,7 @@ config SENSORS_W83L785TS config SENSORS_W83627HF tristate "Winbond W83627HF, W83627THF, W83637HF, W83687THF, W83697HF" - depends on HWMON && I2C - select I2C_ISA + depends on HWMON select HWMON_VID help If you say yes here you get support for the Winbond W836X7 series
drivers/hwmon/w83627hf.c +310 -265
1,069 lines not on this page · raw message
Signature · 1 line
Jean Delvare
PATCH 1/1 w83627hf: Convert to a platform driver
Jean Delvare a ?crit :
Quoted 2 lines
Convert the w83627hf driver from the nonsensical i2c-isa hack to a regular platform driver.
About this driver, w83627hf, Carlos Olalla proposed a patch in order to adds support for pwm clock selection and pwm clock scaling, but this one was not accepted :
http://article.gmane.org/gmane.linux.drivers.sensors/10841.
Since, I haven't seen a patch for pwm clock scaling. Is someone working on this feature ?
Signature · 1 line
Guillaume Millet
PATCH 1/1 w83627hf: Convert to a platform driver
In reply to Jean DelvareHi Guillaume,
Quoted 8 lines · Guillaume Millet
Jean Delvare a ?crit :
Quoted 2 lines
Convert the w83627hf driver from the nonsensical i2c-isa hack to a regular platform driver.
About this driver, w83627hf, Carlos Olalla proposed a patch in order to adds support for pwm clock selection and pwm clock scaling, but this one was not accepted :
http://article.gmane.org/gmane.linux.drivers.sensors/10841.
That patch wasn't acceptable because it did now follow our standard sysfs interface. File naming was wrong, and more importantly, the values were raw register values instead of frequencies expressed in Hz.
Quoted 2 lines
Since, I haven't seen a patch for pwm clock scaling. Is someone working on this feature ?
I don't think so, I did not see any post or patch about this for months.
Signature · 1 line
Jean Delvare
PATCH 1/1 w83627hf: Convert to a platform driver
In reply to Jean DelvareHey guys
I am going to take a look to it again and will repost the patch soon. In order to not to make the same errors, could you please point me to a lm-sensors driver with pwm
clock interface which follows the standard?
Regards
Carlos
Quoted 20 lines · you
Hi Guillaume,
Quoted 8 lines · Guillaume Millet
Jean Delvare a ?crit :
Quoted 2 lines
Convert the w83627hf driver from the nonsensical i2c-isa hack to a regular platform driver.
About this driver, w83627hf, Carlos Olalla proposed a patch in order to adds support for pwm clock selection and pwm clock scaling, but this one was not accepted :
http://article.gmane.org/gmane.linux.drivers.sensors/10841.That patch wasn't acceptable because it did now follow our standard sysfs interface. File naming was wrong, and more importantly, the values were raw register values instead of frequencies expressed in Hz.
Quoted 2 lines
Since, I haven't seen a patch for pwm clock scaling. Is someone working on this feature ?
I don't think so, I did not see any post or patch about this for months.