Skip to contentSkip to conversation

Distinguish between errors and warnings in modpost

PATCH In review Matthew Wilcox 2 participants 2 messages Oct 7, 2006 – Mar 17, 2007 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Distinguish between errors and warnings in modpost

Some of modpost's warnings are fatal, and some are not. Adopt the compiler distinction between errors and warnings by calling error() for fatal diagnostics and warn() for non-fatal ones.

scripts/mod/modpost.c +19 -3
index 4127796..5530294 100644
@@ -55,6 +55,17 @@ void warn(const char *fmt, ...)
 	va_end(arglist);
 }
 
+void error(const char *fmt, ...)
+{
+	va_list arglist;
+
+	fprintf(stderr, "ERROR: ");
+
+	va_start(arglist, fmt);
+	vfprintf(stderr, fmt, arglist);
+	va_end(arglist);
+}
+
 static int is_vmlinux(const char *modname)
 {
 	const char *myname;
@@ -1207,9 +1218,14 @@ static int add_versions(struct buffer *b
 		exp = find_symbol(s->name);
 		if (!exp || exp->module == mod) {
 			if (have_vmlinux && !s->weak) {
-				warn("\"%s\" [%s.ko] undefined!\n",
-				     s->name, mod->name);
-				err = warn_unresolved ? 0 : 1;
+				if (warn_unresolved) {
+					warn("\"%s\" [%s.ko] undefined!\n",
+					     s->name, mod->name);
+				} else {
+					error("\"%s\" [%s.ko] undefined!\n",
+					      s->name, mod->name);
+					err = 1;
+				}
 			}
 			continue;
 		}
#1 lore raw
Quoted 5 lines · Matthew Wilcox

Some of modpost's warnings are fatal, and some are not. Adopt the compiler distinction between errors and warnings by calling error() for fatal diagnostics and warn() for non-fatal ones.

Applied - but I named it merror to avoid clash with glibc and declared it in modpost.h too.

Sam