Skip to contentSkip to conversation

Make MIPS udelay() preempt safe

PATCH In review Deepak Saxena 3 participants 4 messages Mar 20, 2007 MIPS

lore
Share & tools
lore

Deepak Saxena

author
#0 lore raw

PATCH 1/1 Make MIPS udelay() preempt safe

Fix MIPS udelay to make is preempt safe under DEBUG_PREEMPT

Signed-off-by Manish Lachwani <[email protected]>
Signed-off-by Deepak Saxena <[email protected]>

---

This needs to go into -rt patch set or directly into the MIPS tree. Applies cleanly to 2.6.21-rc4 and 2.6.21-rc3-rt0.

 include/asm-mips/delay.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
include/asm-mips/delay.h +1 -1
Index: linux-2.6.18/include/asm-mips/delay.h
===================================================================
@@ -79,7 +79,7 @@ static inline void __udelay(unsigned lon
 	__delay(usecs);
 }
 
-#define __udelay_val cpu_data[smp_processor_id()].udelay_val
+#define __udelay_val cpu_data[raw_smp_processor_id()].udelay_val
 
 #define udelay(usecs) __udelay((usecs),__udelay_val)
Signature · 4 lines
Deepak Saxena - [email protected] - http://www.plexity.net

In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertolt Brecht
author
#1 lore raw

Nevermind on this one. I just noticed that the original patch is not needed.

~Deepak

On Mar 19 2007, at 16:49, Deepak Saxena was caught saying:

Quoted 32 lines

Fix MIPS udelay to make is preempt safe under DEBUG_PREEMPT

Signed-off-by Manish Lachwani <[email protected]>
Signed-off-by Deepak Saxena <[email protected]>

---

This needs to go into -rt patch set or directly into the MIPS tree. Applies cleanly to 2.6.21-rc4 and 2.6.21-rc3-rt0.

 include/asm-mips/delay.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.18/include/asm-mips/delay.h
===================================================================

include/asm-mips/delay.h +1 -1
@@ -79,7 +79,7 @@ static inline void __udelay(unsigned lon
 	__delay(usecs);
 }
 
-#define __udelay_val cpu_data[smp_processor_id()].udelay_val
+#define __udelay_val cpu_data[raw_smp_processor_id()].udelay_val
 
 #define udelay(usecs) __udelay((usecs),__udelay_val)
Signature · 5 lines
-- 
Deepak Saxena - [email protected] - http://www.plexity.net

In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertolt Brecht
Signature · 4 lines
Deepak Saxena - [email protected] - http://www.plexity.net

In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertolt Brecht
#2 lore raw
Quoted 2 lines · Deepak Saxena

Nevermind on this one. I just noticed that the original patch is not needed.

Why? I think the patch is needed to silence error message with CONFIG_DEBUG_PREEMPT.

---
Atsushi Nemoto

#3 lore raw
In reply to Deepak Saxena
Quoted 1 line · Deepak Saxena

Fix MIPS udelay to make is preempt safe under DEBUG_PREEMPT

I don't understand why you're withdrawing this patch - it makes perfect sense as Atsushi has also already found, so I'm going to apply it.

Ralf