Skip to contentSkip to conversation

update-hook: abort early if the project description is unset

PATCH In review Andy Parkins 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 update-hook: abort early if the project description is unset

It was annoying to always have the first email from a project be from the "Unnamed repository; edit this file to name it for gitweb project"; just because it's so easy to forget to set it.

This patch checks to see if the description file is still default (or empty) and aborts if so - allowing you to fix the problem before sending out silly looking emails to every developer.

---
 templates/hooks--update |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
templates/hooks--update +6 -0
index 8f6c4fe..1a60773 100644
@@ -56,6 +56,12 @@ recipients=$(git-repo-config hooks.mailinglist)
 announcerecipients=$(git-repo-config hooks.announcelist)
 allowunannotated=$(git-repo-config --bool hooks.allowunannotated)
 
+# check for no description
+if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb" ]; then
+	echo "*** Project description file hasn't been set" >&2
+	exit 1
+fi
+
 # --- Check types
 newrev_type=$(git-cat-file -t $newrev)
 
Signature · 1 line
1.5.0.3.402.g0c48