Skip to contentSkip to conversation

Export not_critical_when_idle feature in workqueue and use it in ondemand

PATCH Pallipadi, Venkatesh 2 participants 2 messages Mar 20, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 19 lines

-----Original Message-----
From: Dave Jones [mailto:[email protected]]
Sent: Tuesday, March 20, 2007 7:58 AM
To: Pallipadi, Venkatesh
Cc: Andrew Morton; [email protected]; linux-kernel
Subject: Re: [PATCH 2/2] Export not_critical_when_idle feature in workqueue and use it in ondemand

Quoted 3 lines · Venkatesh Pallipadi

Add a new not_critical_when_idle parameter to

queue_delayed_work_on(). This

Quoted 2 lines

parameter can be used to schedule work that are 'unimportant' when CPU is idle and can be called later, when CPU eventually

comes out of idle.

Quoted 1 line
Quoted 9 lines
Quoted 3 lines

Use this parameter in cpufreq ondemand governor.

just for kicks (actually because I was seeing the negative effects of not having this diff) I threw this in the Fedora devel kernel. Got a few people reporting softlockups during shutdown. jpeg from one user attached..

Thanks for the report. I will take a look at this message. Looks like, this error is either coming from rmmod or changing the governor to default from ondemand during reboot. Does Fedora use ondemand as a module and rmmod on reboot or is it builtin?

Thanks,
Venki

#2 lore raw
Quoted 9 lines · Venkatesh
Quoted 4 lines

just for kicks (actually because I was seeing the negative effects of not having this diff) I threw this in the Fedora devel kernel. Got a few people reporting softlockups during shutdown. jpeg from one user attached..

Thanks for the report. I will take a look at this message. Looks like, this error is either coming from rmmod or changing the governor to default from ondemand during reboot. Does Fedora use ondemand as a module and rmmod on reboot or is it builtin?

Yes, it's modular.

Dave

Signature · 1 line
http://www.codemonkey.org.uk