Skip to contentSkip to conversation

: Fix for follows48

PATCH New Gerrit Renker 1 participant 1 message Mar 20, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 13/31 : Fix for follows48

The follows48 relation identifies whether 48-bit sequence number x is the direct successor of y. Currently, it does not handle cases of the following type correctly:

	follows48(0x(prefix)10000LL, 0x(prefix)0FFFFLL)

where prefix is an arbitrary hex sequence of up to 7 digits.

This is fixed by reusing the new dccp_delta_seqno function.

---
 net/dccp/dccp.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
net/dccp/dccp.h +1 -3
index 287a040..2c5be61 100644
@@ -144,9 +144,7 @@ static inline u64 max48(const u64 seq1, const u64 seq2)
 /* is seq1 next seqno after seq2 */
 static inline int follows48(const u64 seq1, const u64 seq2)
 {
-	int diff = (seq1 & 0xFFFF) - (seq2 & 0xFFFF);
-
-	return diff==1;
+	return dccp_delta_seqno(seq2, seq1) == 1;
 }
 
 enum {
Signature · 1 line
1.5.0.3