Define CLONE_NEWPID flag
PATCH 1/1 Define CLONE_NEWPID flag
This was discussed on containers and we thought it would be useful to reserve this flag.
---
From: Sukadev Bhattiprolu <[email protected]>
Subject: [PATCH] Define CLONE_NEWPID flag
Define CLONE_NEWPID flag that will be used to clone pid namespaces.
--- include/linux/sched.h | 1 + 1 file changed, 1 insertion(+)
include/linux/sched.h +1 -0
@@ -26,6 +26,7 @@#define CLONE_STOPPED 0x02000000/* Start in stopped state */ #define CLONE_NEWUTS 0x04000000/* New utsname group? */ #define CLONE_NEWIPC 0x08000000/* New ipcs */ +#define CLONE_NEWPID 0x10000000/* New pid namespace */ /* * Scheduling policies
Quoted 20 lines · On Wed, 21 Mar 2007 12:41:03 -0700 [email protected] wrote:
This was discussed on containers and we thought it would be useful to reserve this flag.
---From: Sukadev Bhattiprolu <[email protected]>
Subject: [PATCH] DefineCLONE_NEWPIDflagDefine
CLONE_NEWPIDflag that will be used to clone pid namespaces.Signed-off-by Sukadev Bhattiprolu <[email protected]>--- include/linux/sched.h | 1 + 1 file changed, 1 insertion(+)Index:
lx26-21-rc3-mm2/include/linux/sched.h
===================================================================
include/linux/sched.h line 30
Quoted 5 lines
include/linux/sched.h +1
-0@@ -26,6 +26,7 @@#define CLONE_STOPPED 0x02000000/* Start in stopped state */ #define CLONE_NEWUTS 0x04000000/* New utsname group? */ #define CLONE_NEWIPC 0x08000000/* New ipcs */ +#define CLONE_NEWPID 0x10000000/* New pid namespace */
Do we actually have any need to reserve it at this time? I'd have thought that we could defer adding this until we have some code in-kernel which uses it.
Quoted 4 lines · Andrew Morton
Quoted 3 lines
Index:
lx26-21-rc3-mm2/include/linux/sched.h
===================================================================
---lx26-21-rc3-mm2.orig/include/linux/sched.h2007-03-20 20:13:19.000000000-0700
Quoted 11 lines
include/linux/sched.h line 30
Quoted 7 lines
+++
lx26-21-rc3-mm2/include/linux/sched.h2007-03-21 11:10:33.000000000 -0700include/linux/sched.h +1
-0@@ -26,6 +26,7 @@#define CLONE_STOPPED 0x02000000/* Start in stopped state */ #define CLONE_NEWUTS 0x04000000/* New utsname group? */ #define CLONE_NEWIPC 0x08000000/* New ipcs */ +#define CLONE_NEWPID 0x10000000/* New pid namespace */ Do we actually have any need to reserve it at this time? I'd have thought that we could defer adding this until we have some code in-kernel which uses it.
In practice this is pretty much reserved already but I understand the sentiment.
Currently the plan is to work on the core pid namespace and get those functions merged at least to -mm with a big fat CONFIG_EXPERIMENTAL so people can really understand what we are talking about when we say a pid_namespace. Then go through and finish up all converting the rest of the pid uses that we haven't tackled yet. There aren't that many left and most of the remaining conversions only make sense in the context of a pid namespace.
Currently we are one or two review cycles away from being able to push out the core pid namespace code.
Further it is actually critical that we have a clone flag for the pid namespace because unshare is very much harder if it is possible at all.
Personally if you want to delay it a week or two, until the rest of the code is ready that is fine. Mostly getting it out now is about release early and release often.
Eric
Quoted 17 lines · Andrew Morton
Quoted 14 lines · On Wed, 21 Mar 2007 12:41:03 -0700 [email protected] wrote:
This was discussed on containers and we thought it would be useful to reserve this flag.
---From: Sukadev Bhattiprolu <[email protected]>
Subject: [PATCH] DefineCLONE_NEWPIDflagDefine
CLONE_NEWPIDflag that will be used to clone pid namespaces.Signed-off-by Sukadev Bhattiprolu <[email protected]>--- include/linux/sched.h | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
include/linux/sched.h line 29
Quoted 9 lines
Index:
lx26-21-rc3-mm2/include/linux/sched.h
===================================================================include/linux/sched.h +1
-0@@ -26,6 +26,7 @@#define CLONE_STOPPED 0x02000000/* Start in stopped state */ #define CLONE_NEWUTS 0x04000000/* New utsname group? */ #define CLONE_NEWIPC 0x08000000/* New ipcs */ +#define CLONE_NEWPID 0x10000000/* New pid namespace */ Do we actually have any need to reserve it at this time? I'd have thought that we could defer adding this until we have some code in-kernel which uses it.
FWIW, I'm fine with the reservation, we won't get around it for the pid space, so we can as well register it now YMMV
best,
Herbert
Quoted 4 lines
_______________________________________________
Containers mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/containers