Skip to contentSkip to conversation

Suspend to disk bug 2.6.21-rc2-git1

DISCUSSION Lukas Hejtmanek 3 participants 8 messages Mar 5, 2007 – Mar 22, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello,

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Signature · 1 line
Lukáš Hejtmánek
#1 lore raw

Hi!

Quoted 3 lines

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Is 2.6.21-latest better? There were many problems in suspend area, hopefully they are slowly being fixed...

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw
Quoted 8 lines · Pavel Machek

Hi!

Quoted 3 lines

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Is 2.6.21-latest better? There were many problems in suspend area, hopefully they are slowly being fixed...

2.6.21-rc3-git with platform (previous method was reboot) method works OK.

Signature · 1 line
Lukáš Hejtmánek
#3 lore raw
In reply to Pavel Machek

Hello,

Quoted 6 lines · Pavel Machek
Quoted 3 lines

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Is 2.6.21-latest better? There were many problems in suspend area, hopefully they are slowly being fixed...

I've found out that only platform method is working. reboot method does not.

Signature · 1 line
Lukáš Hejtmánek
#4 lore raw

Hi!

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Is 2.6.21-latest better? There were many problems in suspend area, hopefully they are slowly being fixed...

I've found out that only platform method is working. reboot method does not.

Try this one.
Pavel

Fix reboot mode blinking moon icon after resume.

---
commit 5958dbea2ea6147f4fd0477b303be752d5c4f53a
tree 9c032e050d09201f66e1706fef4d7bbe8e55c418
parent 2744ccbdcc03f36d193fe20fc17698cfb2a1acea
author Pavel <[email protected]> Tue, 20 Mar 2007 16:33:03 +0100 committer Pavel <[email protected]> Tue, 20 Mar 2007 16:33:03 +0100

 kernel/power/disk.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
kernel/power/disk.c +0 -8
index 873cdf8..dee0ff4 100644
@@ -241,18 +241,11 @@ static int software_resume(void)
 		goto Done;
 	}
 
-	error = platform_prepare();
-	if (error) {
-		swsusp_free();
-		goto Thaw;
-	}
-
 	pr_debug("PM: Reading swsusp image.\n");
 
 	error = swsusp_read();
 	if (error) {
 		swsusp_free();
-		platform_finish();
 		goto Thaw;
 	}
 
@@ -270,7 +263,6 @@ static int software_resume(void)
 	enable_nonboot_cpus();
  Free:
 	swsusp_free();
-	platform_finish();
 	device_resume();
 	resume_console();
  Thaw:
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw
Quoted 6 lines · Pavel Machek

Hi!

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Is 2.6.21-latest better? There were many problems in suspend area, hopefully they are slowly being fixed...

I've found out that only platform method is working. reboot method does not.

Try this one.

Good idea.

BTW, we didn't use "platform" during the resume in 2.6.20, so I think this patch should go into 2.6.21.

Greetings,
Rafael

Signature · 3 lines
If you don't have the time to read,
you don't have the time or the tools to write.
		- Stephen King
#6 lore raw

Hi!

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Is 2.6.21-latest better? There were many problems in suspend area, hopefully they are slowly being fixed...

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

I've found out that only platform method is working. reboot method does not.

Try this one.

Good idea.

BTW, we didn't use "platform" during the resume in 2.6.20, so I think this patch should go into 2.6.21.

Yes, I think so. Do you or I do the akpm submission?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#7 lore raw
In reply to Pavel Machek
Quoted 10 lines · Pavel Machek
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

I'm not sure what version did exacly caused susped to disk problems but anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not even emit ACPI interrupts. Suspend to ram works nicely.

Is 2.6.21-latest better? There were many problems in suspend area, hopefully they are slowly being fixed...

I've found out that only platform method is working. reboot method does not.

Try this one.

It seems to be OK. Thanks.

Signature · 1 line
Lukáš Hejtmánek