Skip to contentSkip to conversation

UML - Header cleanup

PATCH In review Jeff Dike 2 participants 3 messages Mar 22, 2007 User-mode Linux (UML)

lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

cover UML - Header cleanup

These are post-2.6.21 material, except that if the new definition of ARRAY_SIZE goes to Linus, patch 1 in this series should go as well.

These patches are a response to the new ARRAY_SIZE. UML had a duplicate definition for the use of the userspace side of things, which can't directly use kernel.h. This header was included everywhere, and had a random collection of stuff in it.

This series first gets UML building again by replacing the old ARRAY_SIZE definition with one that expands to the same token sequence. Then user_util.h is dismantled, primarily into two, more coherent headers, and deleted. ARRAY_SIZE is reintroduced, but in a header which is only included in userspace files, and in its old form, so this version is lacking the extra typechecking.

The final patch in the series is unrelated to the rest - it adds __init declarations to some functions which were lacking them.

Jeff

Signature · 11 lines
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
#1 lore raw
Quoted 2 lines · On Thu, 22 Mar 2007 12:06:40 -0400 Jeff Dike <[email protected]> wrote:

These are post-2.6.21 material, except that if the new definition of ARRAY_SIZE goes to Linus, patch 1 in this series should go as well.

I have the ARRAY_SIZE change queued for 2.6.22.

It looks like the UML change needs to be folded into the same changeset to avoid build breaks?

author
#2 lore raw
Quoted 4 lines · Andrew Morton

I have the ARRAY_SIZE change queued for 2.6.22.

It looks like the UML change needs to be folded into the same changeset to avoid build breaks?

Yes, that would be great.

Jeff

Signature · 11 lines
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel