Add IRQF_IRQPOLL_IRQ flag to allow irqpoll
Subsystems (15)
cover Add IRQF_IRQPOLL_IRQ flag to allow irqpoll
irqpoll is broken on some architectures that don't use the IRQ 0 for the timer interrupt like IA64. This patch adds a IRQF_IRQPOLL_IRQ flag.
Each architecture is handled in a separate pach. As I left the irq == 0 as condition, this should not break existing architectures that use timer_irq == 0 and that I did't address with that patch (because I don't know).
PATCH 1/7 Add IRQF_IRQPOLL_IRQ flag (common code)
This patch adds a IRQF_IRQPOLL_IRQ flag that the interrupt registration code could use for the interrupt it wants to use for IRQ polling.
Because this must not be the timer interrupt, an additional flag was added instead of re-using the IRQF_TIMER constant. Until all architectures will have an IRQF_IRQPOLL_IRQ interrupt, irq == 0 will stay as alternative as it should not break anything.
Also, note_interrupt() is called on CPU-specific interrupts to be used as interrupt source for IRQ polling.
--- include/linux/interrupt.h | 4 ++++ kernel/irq/handle.c | 2 ++ kernel/irq/spurious.c | 4 +++- 3 files changed, 9 insertions(+), 1 deletion(-)
include/linux/interrupt.h +4 -0
@@ -44,6 +44,9 @@* IRQF_TIMER - Flag to mark this interrupt as timer interrupt * IRQF_PERCPU - Interrupt is per cpu * IRQF_NOBALANCING - Flag to exclude this interrupt from irq balancing +* IRQF_IRQPOLL_IRQ - Interrupt is used for polling (only the interrupt that is +* registered first in an shared interrupt is considered for +* performance reasons) */ #define IRQF_DISABLED 0x00000020#define IRQF_SAMPLE_RANDOM 0x00000040
@@ -52,6 +55,7 @@#define IRQF_TIMER 0x00000200#define IRQF_PERCPU 0x00000400#define IRQF_NOBALANCING 0x00000800 +#define IRQF_IRQPOLL_IRQ 0x00001000/* * Migration helpers. Scheduled for removal in 1/2007
kernel/irq/handle.c +2 -0
@@ -180,6 +180,8 @@ fastcall unsigned int __do_IRQ(unsignedif (desc->chip->ack) desc->chip->ack (irq); action_ret =handle_IRQ_event (irq, desc->action); +if (!noirqdebug) +note_interrupt (irq, desc, action_ret); desc->chip->end (irq);return 1 ; }
kernel/irq/spurious.c +3 -1
@@ -146,7 +146,9 @@ void note_interrupt(unsigned int irq, stif (unlikely (irqfixup)) {/* Don't punish working computers */ -if ((irqfixup ==2 && irq ==0 ) || action_ret ==IRQ_NONE ) { +if ((irqfixup ==2 && ((irq ==0 ) || + (desc->action->flags &IRQF_IRQPOLL_IRQ ))) || + action_ret ==IRQ_NONE ) {int ok =misrouted_irq (irq);if (action_ret ==IRQ_NONE ) desc->irqs_unhandled -= ok;
PATCH 2/7 Add IRQF_IRQPOLL_IRQ flag on IA64
In reply to Bernhard WalleAdd IRQF_IRQPOLL_IRQ for the timer interrupt on IA64.
--- arch/ia64/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21-rc4-mm1/arch/ia64/kernel/time.c =================================--- linux-2.6.21-rc4-mm1.orig/arch/ia64/kernel/time.c +++ linux-2.6.21-rc4-mm1/arch/ia64/kernel/time.c
@@ -235,7 +235,7 @@ ia64_init_itm (void)
static struct irqaction timer_irqaction = {
.handler = timer_interrupt,
- .flags = IRQF_DISABLED,
+ .flags = IRQF_DISABLED | IRQF_IRQPOLL_IRQ,
.name = "timer"
};
PATCH 3/7 Add IRQF_IRQPOLL_IRQ flag on x86_64
In reply to Bernhard WalleAdd IRQF_IRQPOLL_IRQ for the timer interrupt on x86_64.
--- arch/x86_64/kernel/time.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
arch/x86_64/kernel/time.c +4 -1
@@ -317,7 +317,10 @@ void __init stop_timer_interrupt(void) }static struct irqaction irq0 = { - timer_interrupt,IRQF_DISABLED ,CPU_MASK_NONE ,"timer" ,NULL ,NULL + .handler = timer_interrupt, + .flags =IRQF_DISABLED |IRQF_IRQPOLL_IRQ , + .mask =CPU_MASK_NONE , + .name ="timer" };void __init time_init (void )
PATCH 4/7 Add IRQF_IRQPOLL_IRQ flag on arm
In reply to Bernhard WalleAdd IRQF_IRQPOLL_IRQ for each timer interrupt.
--- arch/arm/mach-aaec2000/core.c | 2 +- arch/arm/mach-at91/at91rm9200_time.c | 2 +- arch/arm/mach-at91/at91sam926x_time.c | 2 +- arch/arm/mach-clps711x/time.c | 2 +- arch/arm/mach-clps7500/core.c | 2 +- arch/arm/mach-ebsa110/core.c | 2 +- arch/arm/mach-ep93xx/core.c | 2 +- arch/arm/mach-footbridge/dc21285-timer.c | 2 +- arch/arm/mach-footbridge/isa-timer.c | 2 +- arch/arm/mach-h720x/cpu-h7201.c | 2 +- arch/arm/mach-h720x/cpu-h7202.c | 2 +- arch/arm/mach-imx/time.c | 2 +- arch/arm/mach-integrator/core.c | 2 +- arch/arm/mach-ixp2000/core.c | 2 +- arch/arm/mach-ixp23xx/core.c | 2 +- arch/arm/mach-ixp4xx/common.c | 2 +- arch/arm/mach-lh7a40x/time.c | 2 +- arch/arm/mach-netx/time.c | 2 +- arch/arm/mach-ns9xxx/time.c | 2 +- arch/arm/mach-omap1/time.c | 2 +- arch/arm/mach-omap2/timer-gp.c | 2 +- arch/arm/mach-pnx4008/time.c | 2 +- arch/arm/mach-pxa/time.c | 2 +- arch/arm/mach-realview/core.c | 2 +- arch/arm/mach-sa1100/h3600.c | 2 +- arch/arm/mach-sa1100/time.c | 2 +- arch/arm/mach-shark/core.c | 2 +- arch/arm/mach-versatile/core.c | 2 +- arch/arm/plat-iop/time.c | 2 +- arch/arm/plat-omap/timer32k.c | 2 +- arch/arm/plat-s3c24xx/time.c | 2 +- 31 files changed, 31 insertions(+), 31 deletions(-)
arch/arm/mach-aaec2000/core.c +1 -1
@@ -142,7 +142,7 @@ aaec2000_timer_interrupt(int irq, void *static struct irqaction aaec2000_timer_irq = { .name ="AAEC-2000 Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = aaec2000_timer_interrupt, };
arch/arm/mach-at91/at91rm9200_time.c +1 -1
@@ -87,7 +87,7 @@ static irqreturn_t at91rm9200_timer_intestatic struct irqaction at91rm9200_timer_irq = { .name ="at91_tick" , - .flags =IRQF_SHARED |IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_SHARED |IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = at91rm9200_timer_interrupt };
arch/arm/mach-at91/at91sam926x_time.c +1 -1
@@ -66,7 +66,7 @@ static irqreturn_t at91sam926x_timer_intstatic struct irqaction at91sam926x_timer_irq = { .name ="at91_tick" , - .flags =IRQF_SHARED |IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_SHARED |IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = at91sam926x_timer_interrupt };
arch/arm/mach-clps711x/time.c +1 -1
@@ -58,7 +58,7 @@ p720t_timer_interrupt(int irq, void *devstatic struct irqaction clps711x_timer_irq = { .name ="CLPS711x Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = p720t_timer_interrupt, };
arch/arm/mach-clps7500/core.c +1 -1
@@ -316,7 +316,7 @@ clps7500_timer_interrupt(int irq, void *static struct irqaction clps7500_timer_irq = { .name ="CLPS7500 Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = clps7500_timer_interrupt, };
arch/arm/mach-ebsa110/core.c +1 -1
@@ -199,7 +199,7 @@ ebsa110_timer_interrupt(int irq, void *dstatic struct irqaction ebsa110_timer_irq = { .name ="EBSA110 Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = ebsa110_timer_interrupt, };
arch/arm/mach-ep93xx/core.c +1 -1
@@ -116,7 +116,7 @@ static int ep93xx_timer_interrupt(int irstatic struct irqaction ep93xx_timer_irq = { .name ="ep93xx timer" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = ep93xx_timer_interrupt, };
arch/arm/mach-footbridge/dc21285-timer.c +1 -1
@@ -44,7 +44,7 @@ timer1_interrupt(int irq, void *dev_id)static struct irqaction footbridge_timer_irq = { .name ="Timer1 timer tick" , .handler = timer1_interrupt, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , };/*
arch/arm/mach-footbridge/isa-timer.c +1 -1
@@ -73,7 +73,7 @@ isa_timer_interrupt(int irq, void *dev_istatic struct irqaction isa_timer_irq = { .name ="ISA timer tick" , .handler = isa_timer_interrupt, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , };static void __init isa_timer_init (void )
arch/arm/mach-h720x/cpu-h7201.c +1 -1
@@ -41,7 +41,7 @@ h7201_timer_interrupt(int irq, void *devstatic struct irqaction h7201_timer_irq = { .name ="h7201 Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = h7201_timer_interrupt, };
arch/arm/mach-h720x/cpu-h7202.c +1 -1
@@ -170,7 +170,7 @@ static struct irq_chip h7202_timerx_chipstatic struct irqaction h7202_timer_irq = { .name ="h7202 Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = h7202_timer_interrupt, };
arch/arm/mach-imx/time.c +1 -1
@@ -56,7 +56,7 @@ imx_timer_interrupt(int irq, void *dev_istatic struct irqaction imx_timer_irq = { .name ="i.MX Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = imx_timer_interrupt, };
arch/arm/mach-integrator/core.c +1 -1
@@ -282,7 +282,7 @@ integrator_timer_interrupt(int irq, voidstatic struct irqaction integrator_timer_irq = { .name ="Integrator Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = integrator_timer_interrupt, };
arch/arm/mach-ixp2000/core.c +1 -1
@@ -224,7 +224,7 @@ static int ixp2000_timer_interrupt(int istatic struct irqaction ixp2000_timer_irq = { .name ="IXP2000 Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = ixp2000_timer_interrupt, };
arch/arm/mach-ixp23xx/core.c +1 -1
@@ -363,7 +363,7 @@ ixp23xx_timer_interrupt(int irq, void *dstatic struct irqaction ixp23xx_timer_irq = { .name ="IXP23xx Timer Tick" , .handler = ixp23xx_timer_interrupt, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , };void __init ixp23xx_init_timer (void )
arch/arm/mach-ixp4xx/common.c +1 -1
@@ -265,7 +265,7 @@ static irqreturn_t ixp4xx_timer_interrupstatic struct irqaction ixp4xx_timer_irq = { .name ="IXP4xx Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = ixp4xx_timer_interrupt, };
arch/arm/mach-lh7a40x/time.c +1 -1
@@ -53,7 +53,7 @@ lh7a40x_timer_interrupt(int irq, void *dstatic struct irqaction lh7a40x_timer_irq = { .name ="LHA740x Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = lh7a40x_timer_interrupt, };
arch/arm/mach-netx/time.c +1 -1
@@ -47,7 +47,7 @@ netx_timer_interrupt(int irq, void *dev_static struct irqaction netx_timer_irq = { .name ="NetX Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = netx_timer_interrupt, };
arch/arm/mach-ns9xxx/time.c +1 -1
@@ -53,7 +53,7 @@ static unsigned long ns9xxx_timer_gettimstatic struct irqaction ns9xxx_timer_irq = { .name ="NS9xxx Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = ns9xxx_timer_interrupt, };
arch/arm/mach-omap1/time.c +1 -1
@@ -176,7 +176,7 @@ static irqreturn_t omap_mpu_timer_interrstatic struct irqaction omap_mpu_timer_irq = { .name ="mpu timer" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = omap_mpu_timer_interrupt, };
arch/arm/mach-omap2/timer-gp.c +1 -1
@@ -52,7 +52,7 @@ static irqreturn_t omap2_gp_timer_interrstatic struct irqaction omap2_gp_timer_irq = { .name ="gp timer" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = omap2_gp_timer_interrupt, };
arch/arm/mach-pnx4008/time.c +1 -1
@@ -82,7 +82,7 @@ static irqreturn_t pnx4008_timer_interrustatic struct irqaction pnx4008_timer_irq = { .name ="PNX4008 Tick Timer" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = pnx4008_timer_interrupt };
arch/arm/mach-pxa/time.c +1 -1
@@ -97,7 +97,7 @@ pxa_timer_interrupt(int irq, void *dev_istatic struct irqaction pxa_timer_irq = { .name ="PXA Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = pxa_timer_interrupt, };
arch/arm/mach-realview/core.c +1 -1
@@ -549,7 +549,7 @@ static irqreturn_t realview_timer_interrstatic struct irqaction realview_timer_irq = { .name ="RealView Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = realview_timer_interrupt, };
arch/arm/mach-sa1100/h3600.c +1 -1
@@ -740,7 +740,7 @@ static void h3800_IRQ_demux(unsigned intstatic struct irqaction h3800_irq = { .name ="h3800_asic" , .handler = h3800_IRQ_demux, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , };u32 kpio_int_shadow =0 ;
arch/arm/mach-sa1100/time.c +1 -1
@@ -111,7 +111,7 @@ sa1100_timer_interrupt(int irq, void *destatic struct irqaction sa1100_timer_irq = { .name ="SA11xx Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = sa1100_timer_interrupt, };
arch/arm/mach-shark/core.c +1 -1
@@ -90,7 +90,7 @@ shark_timer_interrupt(int irq, void *devstatic struct irqaction shark_timer_irq = { .name ="Shark Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = shark_timer_interrupt, };
arch/arm/mach-versatile/core.c +1 -1
@@ -887,7 +887,7 @@ static irqreturn_t versatile_timer_interstatic struct irqaction versatile_timer_irq = { .name ="Versatile Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = versatile_timer_interrupt, };
arch/arm/plat-iop/time.c +1 -1
@@ -75,7 +75,7 @@ iop_timer_interrupt(int irq, void *dev_istatic struct irqaction iop_timer_irq = { .name ="IOP Timer Tick" , .handler = iop_timer_interrupt, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , };void __init iop_init_time (unsigned long tick_rate)
arch/arm/plat-omap/timer32k.c +1 -1
@@ -279,7 +279,7 @@ static struct dyn_tick_timer omap_dyn_tistatic struct irqaction omap_32k_timer_irq = { .name ="32KHz timer" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = omap_32k_timer_interrupt, };
arch/arm/plat-s3c24xx/time.c +1 -1
@@ -138,7 +138,7 @@ s3c2410_timer_interrupt(int irq, void *dstatic struct irqaction s3c2410_timer_irq = { .name ="S3C2410 Timer Tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .handler = s3c2410_timer_interrupt, };
PATCH 5/7 Add IRQF_IRQPOLL_IRQ flag on sh
In reply to Bernhard WalleAdd IRQF_IRQPOLL_IRQ on each timer interrupt on SH2.
--- arch/sh/kernel/timers/timer-cmt.c | 2 +- arch/sh/kernel/timers/timer-mtu2.c | 2 +- arch/sh/kernel/timers/timer-tmu.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
arch/sh/kernel/timers/timer-cmt.c +1 -1
@@ -115,7 +115,7 @@ static irqreturn_t cmt_timer_interrupt(istatic struct irqaction cmt_irq = { .name ="timer" , .handler = cmt_timer_interrupt, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .mask =CPU_MASK_NONE , };
arch/sh/kernel/timers/timer-mtu2.c +1 -1
@@ -110,7 +110,7 @@ static irqreturn_t mtu2_timer_interrupt(static struct irqaction mtu2_irq = { .name ="timer" , .handler = mtu2_timer_interrupt, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .mask =CPU_MASK_NONE , };
arch/sh/kernel/timers/timer-tmu.c +1 -1
@@ -99,7 +99,7 @@ static irqreturn_t tmu_timer_interrupt(istatic struct irqaction tmu_irq = { .name ="timer" , .handler = tmu_timer_interrupt, - .flags =IRQF_DISABLED |IRQF_TIMER , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_IRQPOLL_IRQ , .mask =CPU_MASK_NONE , };
PATCH 6/7 Add IRQF_IRQPOLL_IRQ flag on parisc
In reply to Bernhard WalleAdd IRQF_IRQPOLL_IRQ to the timer interrupt on parisc.
--- arch/parisc/kernel/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/parisc/kernel/irq.c +1 -1
@@ -388,7 +388,7 @@ void do_cpu_irq_mask(struct pt_regs *regstatic struct irqaction timer_action = { .handler = timer_interrupt, .name ="timer" , - .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_PERCPU , + .flags =IRQF_DISABLED |IRQF_TIMER |IRQF_PERCPU |IRQF_IRQPOLL_IRQ , };#ifdef CONFIG_SMP
PATCH 7/7 Add IRQF_IRQPOLL_IRQ flag on i386
In reply to Bernhard WalleAdd IRQF_IRQPOLL_IRQ to timer interrupts on i386.
--- arch/i386/mach-default/setup.c | 2 +- arch/i386/mach-visws/setup.c | 2 +- arch/i386/mach-voyager/setup.c | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-)
arch/i386/mach-default/setup.c +1 -1
@@ -81,7 +81,7 @@ void __init trap_init_hook(void)static struct irqaction irq0 = { .handler = timer_interrupt, - .flags =IRQF_DISABLED |IRQF_NOBALANCING , + .flags =IRQF_DISABLED |IRQF_NOBALANCING |IRQF_IRQPOLL_IRQ , .mask =CPU_MASK_NONE , .name ="timer" };
arch/i386/mach-visws/setup.c +1 -1
@@ -116,7 +116,7 @@ void __init pre_setup_arch_hook()static struct irqaction irq0 = { .handler = timer_interrupt, - .flags =IRQF_DISABLED , + .flags =IRQF_DISABLED |IRQF_IRQPOLL_IRQ , .name ="timer" , };
arch/i386/mach-voyager/setup.c +6 -1
@@ -40,7 +40,12 @@ void __init trap_init_hook(void) { } -static struct irqaction irq0 = { timer_interrupt,IRQF_DISABLED ,CPU_MASK_NONE ,"timer" ,NULL ,NULL }; +static struct irqaction irq0 = { + .handler = timer_interrupt, + .flags =IRQF_DISABLED |IRQF_IRQPOLL_IRQ , + .mask =CPU_MASK_NONE , + .name ="timer" +};void __init time_init_hook (void ) {
Quoted 2 lines · Bernhard Walle
irqpoll is broken on some architectures that don't use the IRQ 0 for the timer interrupt like IA64. This patch adds a
IRQF_IRQPOLL_IRQflag.
emn, please, cannot we come up with a better name - one that doesn't have "IRQ" 3 (!) times in it?...
Thanks
Guennadi
---
Guennadi Liakhovetski
Quoted 7 lines · Guennadi Liakhovetski
Quoted 2 lines · Bernhard Walle
irqpoll is broken on some architectures that don't use the IRQ 0 for the timer interrupt like IA64. This patch adds a
IRQF_IRQPOLL_IRQflag.emn, please, cannot we come up with a better name - one that doesn't have "IRQ" 3 (!) times in it?...
Well, it was suggested by Andrew. What's your suggestion?
Thanks,
Bernhard
Quoted 10 lines · Bernhard Walle
Quoted 7 lines · Guennadi Liakhovetski
Quoted 2 lines · Bernhard Walle
irqpoll is broken on some architectures that don't use the IRQ 0 for the timer interrupt like IA64. This patch adds a
IRQF_IRQPOLL_IRQflag.emn, please, cannot we come up with a better name - one that doesn't have "IRQ" 3 (!) times in it?...
Well, it was suggested by Andrew. What's your suggestion?
Purely esthetically (ehm, am I saying that?...) your original suggestion to use IRQF_IRQPOLL looks better to me. Or even IRQF_POLL, but, maybe, it's a bit too much of a simplification.
Thanks
Guennadi
---
Guennadi Liakhovetski
Quoted 8 lines · Guennadi Liakhovetski
Quoted 6 lines · Bernhard Walle
Quoted 5 lines · Guennadi Liakhovetski
Quoted 2 lines · Bernhard Walle
irqpoll is broken on some architectures that don't use the IRQ 0 for the timer interrupt like IA64. This patch adds a
IRQF_IRQPOLL_IRQflag.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
emn, please, cannot we come up with a better name - one that doesn't have "IRQ" 3 (!) times in it?...
Well, it was suggested by Andrew. What's your suggestion?
Purely esthetically (ehm, am I saying that?...) your original suggestion to use
IRQF_IRQPOLLlooks better to me. Or evenIRQF_POLL, but, maybe, it's a bit too much of a simplification.
I personally don't care very much about the naming. So I think it's Andrews final decision ...
Thanks,
Bernhard
Quoted 12 lines · Bernhard Walle
Quoted 11 lines · Guennadi Liakhovetski
Quoted 9 lines · Bernhard Walle
Quoted 7 lines · Guennadi Liakhovetski
Quoted 2 lines · Bernhard Walle
irqpoll is broken on some architectures that don't use the IRQ 0 for the timer interrupt like IA64. This patch adds a
IRQF_IRQPOLL_IRQflag.emn, please, cannot we come up with a better name - one that doesn't have "IRQ" 3 (!) times in it?...
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Well, it was suggested by Andrew. What's your suggestion?
Purely esthetically (ehm, am I saying that?...) your original suggestion to use
IRQF_IRQPOLLlooks better to me. Or evenIRQF_POLL, but, maybe, it's a bit too much of a simplification.I personally don't care very much about the naming. So I think it's Andrews final decision ...
Sure. And for him to have a better chance to do this, I'll fix his email address too:-)
Thanks
Guennadi
---
Guennadi Liakhovetski
Quoted 20 lines · On Tue, 27 Mar 2007 07:01:44 +0200 (CEST) Guennadi Liakhovetski…
Quoted 18 lines · Bernhard Walle
Quoted 16 lines · Guennadi Liakhovetski
Quoted 10 lines · Bernhard Walle
Quoted 7 lines · Guennadi Liakhovetski
Quoted 2 lines · Bernhard Walle
irqpoll is broken on some architectures that don't use the IRQ 0 for the timer interrupt like IA64. This patch adds a
IRQF_IRQPOLL_IRQflag.emn, please, cannot we come up with a better name - one that doesn't have "IRQ" 3 (!) times in it?...
Well, it was suggested by Andrew. What's your suggestion?
Purely esthetically (ehm, am I saying that?...) your original suggestion to use
IRQF_IRQPOLLlooks better to me. Or evenIRQF_POLL, but, maybe, it's a bit too much of a simplification.
Quoted 6 lines
Quoted 2 lines
I personally don't care very much about the naming. So I think it's Andrews final decision ...
Sure. And for him to have a better chance to do this, I'll fix his email address too:-)
I don't think I went as daringly far as to suggest the full name, but I must admit that IRQF_IRQPOLL_IRQ is actually logical.