Skip to contentSkip to conversation

arch/x86_64/kernel/early-quirks.c compiler warning

PATCH In review David Brownell 2 participants 2 messages Mar 26, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/x86_64/kernel/early-quirks.c compiler warning

Fix "unused variable" compiler warning on non-SMP x86_64 configs.

arch/x86_64/kernel/early-quirks.c +1 -1
@@ -73,9 +73,9 @@ static void __init ati_bugs(void)
 
 static void intel_bugs(void)
 {
+#ifdef CONFIG_SMP
 	u16 device = read_pci_config_16(0, 0, 0, PCI_DEVICE_ID);
 
-#ifdef CONFIG_SMP
 	if (device == PCI_DEVICE_ID_INTEL_E7320_MCH ||
 	    device == PCI_DEVICE_ID_INTEL_E7520_MCH ||
 	    device == PCI_DEVICE_ID_INTEL_E7525_MCH)
#1 lore raw
Quoted 7 lines · On Mon, 26 Mar 2007 09:17:44 -0700 David Brownell <[email protected]> wrote:

Fix "unused variable" compiler warning on non-SMP x86_64 configs.

arch/x86_64/kernel/early-quirks.c static void __init ati_bugs(void) · line 81

Quoted 10 lines
arch/x86_64/kernel/early-quirks.c +1 -1
@@ -73,9 +73,9 @@ static void __init ati_bugs(void)
 
 static void intel_bugs(void)
 {
+#ifdef CONFIG_SMP
 	u16 device = read_pci_config_16(0, 0, 0, PCI_DEVICE_ID);
 
-#ifdef CONFIG_SMP
 	if (device == PCI_DEVICE_ID_INTEL_E7320_MCH ||
 	    device == PCI_DEVICE_ID_INTEL_E7520_MCH ||
 	    device == PCI_DEVICE_ID_INTEL_E7525_MCH)

This whole function gets removed by ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/patches/revert-x86_64-mm-fix-the-irqbalance-quirk-for-e7320-e7520-e7525 so I think I'll duck the patch. Which is very bad of me, because it means
2.6.21 goes out with this warning. But I don't think many people build
non-SMP x86_64.