Skip to contentSkip to conversation

i386 - fix cmpxchg warning

PATCH In review Jeff Dike 2 participants 3 messages Mar 27, 2007 – Mar 30, 2007

Subsystems (2)
lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

PATCH 1/6 i386 - fix cmpxchg warning

I started getting warnings from atomic.h about cmpxchg not having a prototype. It's declared in system.h, so including that fixes the UML build warnings and has no noticable ill effects on the i386 build.

--

 include/asm-i386/atomic.h |    1 +
 1 file changed, 1 insertion(+)

--

include/asm-i386/atomic.h +1 -0
Index: linux-2.6.21-mm/include/asm-i386/atomic.h
===================================================================
@@ -3,6 +3,7 @@
 
 #include <linux/compiler.h>
 #include <asm/processor.h>
+#include <asm/system.h>
 
 /*
  * Atomic operations that C can't guarantee us.  Useful for
#1 lore raw
Quoted 4 lines

#include <linux/compiler.h>
#include <asm/processor.h>
+#include <asm/system.h>

Sorry no. system.h is the header from hell and putting it into a "basic" header like atomic_t will likely cause all kinds of problems.

If it's a real issue move cmpxchhg into a different header and include that from system.h and atomic.h. system.h has too much stuff anyways so it could use any cleanup.

-Andi

author
#2 lore raw
Quoted 7 lines · Andi Kleen
Quoted 4 lines

#include <linux/compiler.h>
#include <asm/processor.h>
+#include <asm/system.h>

Sorry no. system.h is the header from hell and putting it into a "basic" header like atomic_t will likely cause all kinds of problems.

OK, I'll figure out someplace else for it.

Jeff

Signature · 11 lines
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel