aio: remove bare user-triggerable error printk
PATCH 1/1 aio: remove bare user-triggerable error printk
aio: remove bare user-triggerable error printk
The user can generate console output if they cause do_mmap() to fail during sys_io_setup(). This was seen in a regression test that does exactly that by spinning calling mmap() until it gets -ENOMEM before calling io_setup().
We don't need this printk all, just remove it.
---
fs/aio.c | 1 - 1 file changed, 1 deletion(-)
fs/aio.c +0 -1
@@ -136,7 +136,6 @@ static int aio_setup_ring(struct kioctx 0);if (IS_ERR ((void *)info->mmap_base)) {up_write (&ctx->mm->mmap_sem); -printk ("mmap err: %ld\n" , -info->mmap_base); info->mmap_size =0 ;aio_free_ring (ctx);return -EAGAIN ;
Quoted 1 line
We don't need this printk all, just remove it.
("at all". Sigh.)
- z
Benjamin LaHaise
maintainerQuoted 7 lines · Zach Brown
The user can generate console output if they cause
do_mmap()to fail duringsys_io_setup(). This was seen in a regression test that does exactly that by spinning callingmmap()until it gets-ENOMEMbefore callingio_setup().We don't need this printk all, just remove it.
Signed-off-by Zach Brown <[email protected]>
Yes. Please!
-ben
Signature · 2 lines
"Time is of no importance, Mr. President, only life is important." Don't Email: <[email protected]>.
==> On Tue, 27 Mar 2007 15:44:01 -0700 (PDT), Zach Brown <[email protected]> said:
Zach> aio: remove bare user-triggerable error printk The user can Zach> generate console output if they cause do_mmap() to fail during Zach> sys_io_setup(). This was seen in a regression test that does Zach> exactly that by spinning calling mmap() until it gets -ENOMEM Zach> before calling io_setup().
Zach> We don't need this printk all, just remove it.
ACK.
Zach> Signed-off-by: Zach Brown <[email protected]> ---
-Jeff