Skip to contentSkip to conversation

CPUSETS: add mems to basic usage documentation

PATCH In review Simon Horman 2 participants 3 messages Mar 30, 2007 – Mar 31, 2007 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CPUSETS: add mems to basic usage documentation

It seems that there must be at least one node in mems and at least one CPU in cpus in order to be able to assign tasks to a cpuset. This makes sense. And I think it would also make sense to include a mems setting in the basic usage section of the documentation.

I also wonder if something logged to dmsg, explaining why a write failed, would be a good enhancement. I ended up having rummage arround in cpuset.c in order to work out why my configuration was failing.

Documentation/cpusets.txt +3 -0
Index: linux-2.6/Documentation/cpusets.txt
===================================================================
@@ -557,6 +557,9 @@
 Add some cpus:
 # /bin/echo 0-7 > cpus
 
+Add some mems:
+# /bin/echo 0-7 > mems
+
 Now attach your shell to this cpuset:
 # /bin/echo $$ > tasks
 
Acked-by on v1 1/1
#1 lore raw

Documentation/cpusets.txt line 561

Quoted 4 lines · Simon Horman

+++ linux-2.6/Documentation/cpusets.txt 2007-03-30 13:03:19.000000000 +0900
...

Documentation/cpusets.txt +2 -0
+Add some mems:
+# /bin/echo 0-7 > mems

Nice change - thanks.

(I probably would not add a dmesg complaint; we don't usually do that for ordinary system call failures. Pay close attention to the resulting errno - in this case ENOSPC.)

Signature · 3 lines
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <[email protected]> 1.925.600.0401
#2 lore raw
Quoted 9 lines · Paul Jackson

Documentation/cpusets.txt line 561

Quoted 4 lines · Simon Horman

+++ linux-2.6/Documentation/cpusets.txt 2007-03-30 13:03:19.000000000 +0900
...

Documentation/cpusets.txt +2 -0
+Add some mems:
+# /bin/echo 0-7 > mems

Nice change - thanks.

Thanks

Quoted 3 lines

(I probably would not add a dmesg complaint; we don't usually do that for ordinary system call failures. Pay close attention to the resulting errno - in this case ENOSPC.)

Understood

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/