Skip to contentSkip to conversation

update Documentation/driver-model/platform.txt

PATCH In review David Brownell 3 participants 3 messages Mar 31, 2007 – Apr 2, 2007 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 update Documentation/driver-model/platform.txt

Make note of the legacy "probe-the-hardware" drivers, and some APIs that are mostly unused except by such drivers. We probably can't escape having legacy drivers for a while (e.g. old ISA drivers), but we can at least discourage this style code for new drivers, and unless it's unavoidable.

Documentation/driver-model/platform.txt +40 -0
@@ -96,6 +96,46 @@ System setup also associates those clock
 calls to clk_get(&pdev->dev, clock_name) return them as needed.
 
 
+Legacy Drivers:  Device Probing
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Some drivers are not fully converted to the driver model, because they take
+on a non-driver role:  the driver registers its platform device, rather than
+leaving that for system infrastructure.  Such drivers can't be hotplugged
+or coldplugged, since those mechanisms require device creation to be in a
+different system component than the driver.
+
+The only "good" reason for this is to handle older system designs which, like
+original IBM PCs, rely on error-prone "probe-the-hardware" models for hardware
+configuration.  Newer systems have largely abandoned that model, in favor of
+bus-level support for dynamic configuration (PCI, USB), or device tables
+provided by the boot firmware (e.g. PNPACPI on x86).  There are too many
+conflicting options about what might be where, and even educated guesses by
+an operating system will be wrong often enough to make trouble.
+
+This style of driver is discouraged.  If you're updating such a driver,
+please try to move the device enumeration to a more appropriate location,
+outside the driver.  This will usually be cleanup, since such drivers
+tend to already have "normal" modes, such as ones using device nodes that
+were created by PNP or by platform device setup.
+
+None the less, there are some APIs to support such legacy drivers.  Avoid
+using these calls except with such hotplug-deficient drivers.
+
+	struct platform_device *platform_device_alloc(
+			char *name, unsigned id);
+
+You can use platform_device_alloc() to dynamically allocate a device, which
+you will then initialize with resources and platform_device_register().
+A better solution is usually:
+
+	struct platform_device *platform_device_register_simple(
+			char *name, unsigned id,
+			struct resource *res, unsigned nres);
+
+You can use platform_device_register_simple() as a one-step call to allocate
+and register a device.
+
+
 Device Naming and Driver Binding
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 The platform_device.dev.bus_id is the canonical name for the devices.
#1 lore raw

Documentation/driver-model/platform.txt System setup also associates those clock · line 136

Quoted 8 lines · David Brownell
Documentation/driver-model/platform.txt +8 -0
+A better solution is usually:
+
+       struct platform_device *platform_device_register_simple(
+                       char *name, unsigned id,
+                       struct resource *res, unsigned nres);
+
+You can use platform_device_register_simple() as a one-step call to allocate
+and register a device.

DIdn't Russell want to convert eberything to platform_device_alloc and then nuke platfrom_device_register_simple()?

Signature · 1 line
Dmitry
#2 lore raw
Quoted 13 lines · Dmitry Torokhov
Quoted 9 lines · David Brownell
Documentation/driver-model/platform.txt +7 -0
+A better solution is usually:
+
+       struct platform_device *platform_device_register_simple(
+                       char *name, unsigned id,
+                       struct resource *res, unsigned nres);
+
+You can use platform_device_register_simple() as a one-step call to 

allocate
+and register a device.

DIdn't Russell want to convert eberything to platform_device_alloc and then nuke platfrom_device_register_simple()?

That was my long term plan - since I don't like APIs which "grow" lots of different and redundant interfaces.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of: