Skip to contentSkip to conversation

mm: spelling error in a comment

PATCH In review Charles Clément 3 participants 4 messages Apr 2, 2007 – Apr 3, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: spelling error in a comment

Fix spelling in a comment in mm/slab.c.

---

Index: linux-2.6.21-rc5/mm/slab.c =================================--- linux-2.6.21-rc5.orig/mm/slab.c +++ linux-2.6.21-rc5/mm/slab.c
@@ -451,7 +451,7 @@ struct kmem_cache {

#define BATCHREFILL_LIMIT 16
/*
- * Optimization question: fewer reaps means less probability for unnessary
+ * Optimization question: fewer reaps means less probability for unnecessary
* cpucache drain/refill cycles.
*
* OTOH the cpuarrays can contain lots of objects,

Signature · 5 lines
Charles Clément.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
#1 lore raw
Quoted 4 lines · On Mon, 2 Apr 2007 23:06:36 +0200 Charles Clement wrote:

Fix spelling in a comment in mm/slab.c.

Alexey can grab this if he wants to (or Adrian could), but here's what Andrew Morton has to say about such patches:

http://marc.info/?l=kernel-janitor-discuss&m=117360826232574&w=2

"...I prefer not to do spello and grammaro
fixes, unless they're in something user-visible: a printk or documentation. Simply because there would be no end to it."

Quoted 23 lines

---

Index: linux-2.6.21-rc5/mm/slab.c
===================================================================

mm/slab.c +1 -1
@@ -451,7 +451,7 @@ struct kmem_cache {
 
 #define BATCHREFILL_LIMIT	16
 /*
- * Optimization question: fewer reaps means less probability for unnessary
+ * Optimization question: fewer reaps means less probability for unnecessary
  * cpucache drain/refill cycles.
  *
  * OTOH the cpuarrays can contain lots of objects,
Signature · 6 lines
-- 
Charles Clement.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#2 lore raw
Quoted 8 lines · Randy Dunlap
Quoted 4 lines · On Mon, 2 Apr 2007 23:06:36 +0200 Charles Clément wrote:

Fix spelling in a comment in mm/slab.c.

Quoted 10 lines

Alexey can grab this if he wants to (or Adrian could), but here's what Andrew Morton has to say about such patches:

http://marc.info/?l=kernel-janitor-discuss&m7360826232574&w=2

"...I prefer not to do spello and grammaro
fixes, unless they're in something user-visible: a printk or documentation. Simply because there would be no end to it."

Also, regardless if it is a comment or not, I think it may be a good idea to put such uncommon mistakes in KJ's wiki under "Spelling mistakes" and let it all be taken care of once in a while.
(http://fsdev.net/wiki/index.php?title=Spelling_mistakes)

Richard Knutsson

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

#3 lore raw
Quoted 9 lines · Richard Knutsson
Quoted 8 lines · Randy Dunlap
Quoted 4 lines · On Mon, 2 Apr 2007 23:06:36 +0200 Charles Clément wrote:

Fix spelling in a comment in mm/slab.c.

"...I prefer not to do spello and grammaro
fixes, unless they're in something user-visible: a printk or documentation. Simply because there would be no end to it."

Ok, I didn't know that, thank you.

Quoted 6 lines

Also, regardless if it is a comment or not, I think it may be a good idea to put such uncommon mistakes in KJ's wiki under "Spelling mistakes" and let it all be taken care of once in a while.
(http://fsdev.net/wiki/index.php?title=Spelling_mistakes)

Richard Knutsson

Yes, I agree with that but it then should be accessible, as with a patchset. Or maybe the solution to this is simply to send them to the trivial patch adress.

Signature · 5 lines
Charles Clément.
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors