Skip to contentSkip to conversation

use unsigned char in smc91111 driver for mac

PATCH New Mike Frysinger 3 participants 4 messages Apr 4, 2007 – Apr 20, 2007

lore
Share & tools
lore

Mike Frysinger

author
#0 lore raw

PATCH 1/1 use unsigned char in smc91111 driver for mac

the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like:
0xFFFFFFE0 and that's no good
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: driver-smc91111.diff
Type: text/x-diff
Size: 1299 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070403/10324301/attachment.diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070403/10324301/attachment.pgp

#1 lore raw

PATCH 1/1 use unsigned char in smc91111 driver for mac

Quoted 5 lines · In message <[email protected]> you wrote:

the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like:
0xFFFFFFE0 and that's no good

Dear Mike - good patch, but Signed-off-by: line is missing...

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Knowledge, sir, should be free to all!
	-- Harry Mudd, "I, Mudd", stardate 4513.3
author
#2 lore raw

PATCH 1/1 use unsigned char in smc91111 driver for mac

Quoted 7 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:

the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like:
0xFFFFFFE0 and that's no good

Dear Mike - good patch, but Signed-off-by: line is missing...

Signed-off-by Mike Frysinger <[email protected]>

-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070404/269d63a3/attachment.pgp

#3 lore raw

PATCH 1/1 use unsigned char in smc91111 driver for mac

Quoted 7 lines · Mike Frysinger
Quoted 6 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:

the v_mac variable in the smc91111 driver is declared as a signed char ... this causes problems when one of the bytes in the MAC is "signed" like 0xE0 because when it gets printed out, you get a display like:
0xFFFFFFE0 and that's no good

Quoted 5 lines
Quoted 1 line

Dear Mike - good patch, but Signed-off-by: line is missing...

Signed-off-by Mike Frysinger <[email protected]>

-mike

Just want to know the status of this patch, thanks.

Best Regards,
-Aubrey