Skip to contentSkip to conversation

swsusp: Fix memory shrinker

PATCH New Rafael J. Wysocki 1 participant 1 message Apr 3, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 swsusp: Fix memory shrinker

Hi,

I think this is 2.6.21 material.

---
From: Rafael J. Wysocki <[email protected]>

Fix a bug in the swsusp's memory shrinker that causes some systems using highmem to refuse to suspend to disk if image_size is set above 1/2 of available RAM.

Special thanks to Jiri Slaby for reporting the problem and assistance in debugging it.

---
 kernel/power/swsusp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/power/swsusp.c +1 -1
Index: linux-2.6.21-rc5/kernel/power/swsusp.c
===================================================================
@@ -229,13 +229,13 @@ int swsusp_shrink_memory(void)
 		size += highmem_size;
 		for_each_zone (zone)
 			if (populated_zone(zone)) {
+				tmp += snapshot_additional_pages(zone);
 				if (is_highmem(zone)) {
 					highmem_size -=
 					zone_page_state(zone, NR_FREE_PAGES);
 				} else {
 					tmp -= zone_page_state(zone, NR_FREE_PAGES);
 					tmp += zone->lowmem_reserve[ZONE_NORMAL];
-					tmp += snapshot_additional_pages(zone);
 				}
 			}