Skip to contentSkip to conversation

kernel/time.c: add missing symbol exports

PATCH In review Thomas Bittermann 5 participants 8 messages Apr 4, 2007

lore
Share & tools
lore

Thomas Bittermann

author
#0 lore raw

PATCH 1/1 kernel/time.c: add missing symbol exports

From: Thomas Bittermann <[email protected]>

This patch adds 2 missing symbol exports:

jiffies_to_timeval
timeval_to_jiffies

Signed-off-by Thomas Bittermann <[email protected]>
---
 kernel/time.c |    2 ++
 1 file changed, 2 insertions(+)
kernel/time.c 2007-04-04 21:39:14.000000000 +0200 renamed from kernel/time.c 2007-04-04 21:39:02.000000000 +0200 +2 -0
Index: linux-2.6.21-rc5.fix/kernel/time.c
===================================================================
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval
                (((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
                 (USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
 }
+EXPORT_SYMBOL(timeval_to_jiffies);
 
 void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 {

@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned l
        tv_usec /= NSEC_PER_USEC;
        value->tv_usec = tv_usec;
 }
+EXPORT_SYMBOL(jiffies_to_timeval);
 
 /*
  * Convert jiffies/jiffies_64 to clock_t and back.
#1 lore raw
Quoted 4 lines · On Wed, 04 Apr 2007 22:20:54 +0200 Thomas Bittermann <[email protected]>…

This patch adds 2 missing symbol exports:

jiffies_to_timeval
timeval_to_jiffies

I don't see any in-tree code which needs these symbols?

The exports might make sense from a consistency POV, but I'd be interested in knowing what motivated this change?

author
#2 lore raw
Quoted 5 lines · Andrew Morton
Quoted 2 lines · On Wed, 04 Apr 2007 22:20:54 +0200 Thomas Bittermann <[email protected]>…

This patch adds 2 missing symbol exports:

Quoted 7 lines
Quoted 2 lines

jiffies_to_timeval
timeval_to_jiffies

I don't see any in-tree code which needs these symbols?

The exports might make sense from a consistency POV, but I'd be interested in knowing what motivated this change?

I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
(http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses jiffies_to_timeval() ...

Thanks for your quick response.

Thomas

#3 lore raw
Quoted 9 lines · On Wed, 04 Apr 2007 23:13:11 +0200 Thomas Bittermann <[email protected]>…
Quoted 8 lines · Andrew Morton
Quoted 4 lines · On Wed, 04 Apr 2007 22:20:54 +0200 Thomas Bittermann <[email protected]>…

This patch adds 2 missing symbol exports:

jiffies_to_timeval
timeval_to_jiffies

Quoted 8 lines
Quoted 4 lines

I don't see any in-tree code which needs these symbols?

The exports might make sense from a consistency POV, but I'd be interested in knowing what motivated this change?

I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
(http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses jiffies_to_timeval() ...

Fair enough.

John/Ingo/Thomas: have you any problems with exporting the above to modules (with EXPORT_SYMBOL)?

#4 lore raw
Quoted 8 lines · Andrew Morton
Quoted 3 lines

I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
(http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme).
dm-raid4-5.c uses jiffies_to_timeval() ...

Fair enough.

John/Ingo/Thomas: have you any problems with exporting the above to modules (with EXPORT_SYMBOL)?

i have no problems with that. I think it was even a traditional api, but inlined.

Ingo

author
#5 lore raw
Quoted 5 lines · Ingo Molnar
Quoted 3 lines · Andrew Morton
Quoted 3 lines

I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
(http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme).
dm-raid4-5.c uses jiffies_to_timeval() ...

Quoted 7 lines
Quoted 4 lines

Fair enough.

John/Ingo/Thomas: have you any problems with exporting the above to modules (with EXPORT_SYMBOL)?

i have no problems with that. I think it was even a traditional api, but inlined.

Yes it was inlined before and got lost somewhere between 2.6.20 and 2.6.21-rcX - don't know exactly which one it was (see http://lkml.org/lkml/2007/1/23/198)

Cheers & thanks
Thomas

#6 lore raw
In reply to Andrew Morton
Quoted 21 lines · Andrew Morton
Quoted 9 lines · On Wed, 04 Apr 2007 23:13:11 +0200 Thomas Bittermann <[email protected]>…
Quoted 8 lines · Andrew Morton
Quoted 4 lines · On Wed, 04 Apr 2007 22:20:54 +0200 Thomas Bittermann <[email protected]>…

This patch adds 2 missing symbol exports:

jiffies_to_timeval
timeval_to_jiffies

Quoted 8 lines
Quoted 4 lines

I don't see any in-tree code which needs these symbols?

The exports might make sense from a consistency POV, but I'd be interested in knowing what motivated this change?

I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
(http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses jiffies_to_timeval() ...

Quoted 4 lines

Fair enough.

John/Ingo/Thomas: have you any problems with exporting the above to modules (with EXPORT_SYMBOL)?

As long as jiffies and HZ is exported, I don't see why not.

thanks
-john

#7 lore raw
In reply to Andrew Morton
Quoted 21 lines · Andrew Morton
Quoted 9 lines · On Wed, 04 Apr 2007 23:13:11 +0200 Thomas Bittermann <[email protected]>…
Quoted 8 lines · Andrew Morton
Quoted 4 lines · On Wed, 04 Apr 2007 22:20:54 +0200 Thomas Bittermann <[email protected]>…

This patch adds 2 missing symbol exports:

jiffies_to_timeval
timeval_to_jiffies

Quoted 8 lines
Quoted 4 lines

I don't see any in-tree code which needs these symbols?

The exports might make sense from a consistency POV, but I'd be interested in knowing what motivated this change?

I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
(http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses jiffies_to_timeval() ...

Quoted 4 lines

Fair enough.

John/Ingo/Thomas: have you any problems with exporting the above to modules (with EXPORT_SYMBOL)?

Fine with me.

tglx