ACPI: more verbose thermal zone shutdown message

PATCH In review Danny Kukawka 3 participants 4 messages Apr 5, 2007 – Apr 16, 2007

Subsystems (2)

ACPI ACPI thermal driver

lore

Share & tools

lore

Danny Kukawka

author

2007-04-05 14:16 UTC #0 lore raw

PATCH 1/1 ACPI: more verbose thermal zone shutdown message

Hi,

while debug some strange termal shutdowns I wrote this patch to get more information in /var/log/messages about the reason for the shutdown. I think this would be useful in general.

Danny

From: Danny Kukawka <[email protected]>
Subject: ACPI: more verbose thermal zone shutdown message

add more information to acpi thermal zone shutdown message for easier debugging

Signed-off-by Danny Kukawka <[email protected]>

---
 thermal.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

drivers/acpi/thermal.c +9 -3

@@ -457,14 +457,20 @@
 		return -EINVAL;
 
 	if (tz->temperature >= tz->trips.critical.temperature) {
-		printk(KERN_WARNING PREFIX "Critical trip point\n");
+		printk(KERN_WARNING PREFIX 
+		       "Critical trip point (%ld C) reached on thermal zone [%s]\n",
+		       KELVIN_TO_CELSIUS(tz->trips.critical.temperature),
+		       acpi_device_bid(tz->device)); 
 		tz->trips.critical.flags.enabled = 1;
 	} else if (tz->trips.critical.flags.enabled)
 		tz->trips.critical.flags.enabled = 0;
 
 	printk(KERN_EMERG
-	       "Critical temperature reached (%ld C), shutting down.\n",
-	       KELVIN_TO_CELSIUS(tz->temperature));
+	       "Critical temperature reached (%ld C on [%s] with trip point set to: %ld C), shutting down.\n",
+	       KELVIN_TO_CELSIUS(tz->temperature),
+	       acpi_device_bid(tz->device),
+	       KELVIN_TO_CELSIUS(tz->trips.critical.temperature));
+
 	acpi_bus_generate_event(tz->device, ACPI_THERMAL_NOTIFY_CRITICAL,
 				tz->trips.critical.flags.enabled);

Stefan Seyfried

2007-04-05 16:27 UTC #1 lore raw

Quoted 5 lines · Danny Kukawka

Hi,
while debug some strange termal shutdowns I wrote this patch to get more information in /var/log/messages about the reason for the shutdown. I think this would be useful in general.

Yes, especially as these were bogus thermal shutdowns, it is useful for debugging to know from which thermal zone they were initiated.

Quoted 9 lines

Danny
From: Danny Kukawka <[email protected]>
Subject: ACPI: more verbose thermal zone shutdown message
add more information to acpi thermal zone shutdown message for easier debugging
Signed-off-by Danny Kukawka <[email protected]>

FWIW:

Signed-off-by Stefan Seyfried <[email protected]>

Signature · 4 lines

Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out."

Pavel Machek

2007-04-15 19:57 UTC #2 lore raw

In reply to Danny Kukawka

Hi!

Quoted 6 lines

while debug some strange termal shutdowns I wrote this patch to get more information in /var/log/messages about the reason for the shutdown. I think this would be useful in general.
Danny

Quoted 7 lines

From: Danny Kukawka <[email protected]>
Subject: ACPI: more verbose thermal zone shutdown message
add more information to acpi thermal zone shutdown message for easier debugging
Signed-off-by Danny Kukawka <[email protected]>

Yes, please.

(I actually had similar patch in my tree forever).

Quoted 8 lines

drivers/acpi/thermal.c +4 -1

 	if (tz->temperature >= tz->trips.critical.temperature) {
-		printk(KERN_WARNING PREFIX "Critical trip point\n");
+		printk(KERN_WARNING PREFIX 
+		       "Critical trip point (%ld C) reached on thermal zone [%s]\n",
+		       KELVIN_TO_CELSIUS(tz->trips.critical.temperature),
+		       acpi_device_bid(tz->device)); 
 		tz->trips.critical.flags.enabled = 1;
 	} else if (tz->trips.critical.flags.enabled)

drivers/acpi/thermal.c line 473

Quoted 10 lines

drivers/acpi/thermal.c +5 -2

 		tz->trips.critical.flags.enabled = 0;
 
 	printk(KERN_EMERG
-	       "Critical temperature reached (%ld C), shutting down.\n",
-	       KELVIN_TO_CELSIUS(tz->temperature));
+	       "Critical temperature reached (%ld C on [%s] with trip point set to: %ld C), shutting down.\n",
+	       KELVIN_TO_CELSIUS(tz->temperature),
+	       acpi_device_bid(tz->device),
+	       KELVIN_TO_CELSIUS(tz->trips.critical.temperature));
+

Why two printks with same info, and why is one of them WARNING and second EMERG?

Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Danny Kukawka

author

2007-04-16 16:00 UTC #3 lore raw

Quoted 17 lines · Pavel Machek

Hi!
Quoted 6 lines
while debug some strange termal shutdowns I wrote this patch to get more information in /var/log/messages about the reason for the shutdown. I think this would be useful in general.
Danny
Quoted 7 lines
From: Danny Kukawka <[email protected]>
Subject: ACPI: more verbose thermal zone shutdown message
add more information to acpi thermal zone shutdown message for easier debugging
Signed-off-by Danny Kukawka <[email protected]>
Yes, please.

[..]

Quoted 2 lines

Why two printks with same info, and why is one of them WARNING and second EMERG?

I think this is what happen and why there are currently two messages:

* if the temperature is really critical you get (now) this:
----------------
kernel: Critical trip point (102 C) reached on Thermalzone [THM]
kernel: Critical temperature reached (150 C on [THM] with trip point set to:
102 C), shutting down.
----------------

* and if something send a critical temp event to the thermal zone you get:
----------------
kernel: Critical temperature reached (42 C on [THM] with trip point set to:
102 C), shutting down.
----------------

Maybe we can delete the first one, since you get now also from second message the information if the temperature was really critical or if there was an other reason for the shutdown, but in the past this was IMO needed to differ.

Danny