Skip to contentSkip to conversation

irq-devres: fix failure path of devm_request_irq()

PATCH New Tejun Heo 1 participant 1 message Apr 7, 2007 IRQ

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 irq-devres: fix failure path of devm_request_irq()

devres should be deallocated with devres_free() not kfree(). This bug corrupts slab on IRQ request failure. Fix it.

---
Sorry about the bug, please apply before 2.6.21 release. Thanks.

kernel/irq/devres.c +1 -1
index 85a430d..d8ee241 100644
@@ -54,7 +54,7 @@ int devm_request_irq(struct device *dev, unsigned int irq,
 
 	rc = request_irq(irq, handler, irqflags, devname, dev_id);
 	if (rc) {
-		kfree(dr);
+		devres_free(dr);
 		return rc;
 	}