Skip to contentSkip to conversation

zap_other_threads: remove unneeded ->exit_signal change

PATCH In review Oleg Nesterov 2 participants 2 messages Apr 8, 2007 – Apr 9, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zap_other_threads: remove unneeded ->exit_signal change

We already depend on fact that all sub-threads have ->exit_signal == -1, no need to set it in zap_other_threads().

kernel/signal.c renamed from kernel/signal.c~zat +0 -11
@@ -1163,17 +1163,6 @@ void zap_other_threads(struct task_struc
 		if (t->exit_state)
 			continue;
 
-		/*
-		 * We don't want to notify the parent, since we are
-		 * killed as part of a thread group due to another
-		 * thread doing an execve() or similar. So set the
-		 * exit signal to -1 to allow immediate reaping of
-		 * the process.  But don't detach the thread group
-		 * leader.
-		 */
-		if (t != p->group_leader)
-			t->exit_signal = -1;
-
 		/* SIGKILL will be handled before any pending SIGSTOP */
 		sigaddset(&t->pending.signal, SIGKILL);
 		signal_wake_up(t, 1);