Skip to contentSkip to conversation

: Resubmit Fix overloaded use of acpi= on bootline

PATCH In review Prarit Bhargava 2 participants 2 messages Apr 9, 2007 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Resubmit Fix overloaded use of acpi= on bootline

The use of "apic=" on the boot line is overloaded. It is used once to override the type of genapic, and then later on it is used to determine a debug level. Because of this a bogus error message is sent to the console when using the debug option:

Unknown genapic `apic=debug' specified.

This patch changes the genapic situation to use "genapic=".

Documentation/kernel-parameters.txt +3 -0
index ef2ffde..8cbd90c 100644
@@ -589,6 +589,9 @@ and is between 256 and 4096 characters. It is defined in the file
 
 	gamma=		[HW,DRM]
 
+	genapic=	[APIC,i386] Select a specific genapic type to be used.
+			Format: <name>
+
 	gdth=		[HW,SCSI]
 			See header of drivers/scsi/gdth.c.
 
arch/i386/mach-generic/probe.c +1 -1
index a7b3999..cabe31b 100644
@@ -49,7 +49,7 @@ static int __init parse_apic(char *arg)
 	/* Parsed again by __setup for debug/verbose */
 	return 0;
 }
-early_param("apic", parse_apic);
+early_param("genapic", parse_apic);
 
 void __init generic_bigsmp_probe(void)
 {
#1 lore raw
Quoted 10 lines · On Mon, 9 Apr 2007 09:25:47 -0400 Prarit Bhargava wrote:

The use of "apic=" on the boot line is overloaded. It is used once to override the type of genapic, and then later on it is used to determine a debug level. Because of this a bogus error message is sent to the console when using the debug option:

Unknown genapic `apic=debug' specified.

This patch changes the genapic situation to use "genapic=".

Thanks, looks good except that the Subject line could confuse someone (s/acpi/apic/).

Quoted 19 lines
Documentation/kernel-parameters.txt +3 -0
index ef2ffde..8cbd90c 100644
@@ -589,6 +589,9 @@ and is between 256 and 4096 characters. It is defined in the file
 
 	gamma=		[HW,DRM]
 
+	genapic=	[APIC,i386] Select a specific genapic type to be used.
+			Format: <name>
+
 	gdth=		[HW,SCSI]
 			See header of drivers/scsi/gdth.c.
 
arch/i386/mach-generic/probe.c +0 -0
index a7b3999..cabe31b 100644

arch/i386/mach-generic/probe.c static int __init parse_apic(char *arg)

Quoted 9 lines
arch/i386/mach-generic/probe.c +1 -2
@@ -49,7 +49,7 @@ static int __init parse_apic(char *arg)
 	/* Parsed again by __setup for debug/verbose */
 	return 0;
 }
-early_param("apic", parse_apic);
+early_param("genapic", parse_apic);
 
 void __init generic_bigsmp_probe(void)
 {
-

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***