Skip to contentSkip to conversation

powerpc: delete -mstring option

PATCH In review Akinobu Mita 3 participants 4 messages Apr 10, 2007 – Apr 11, 2007 PowerPC

lore
Share & tools
lore

Akinobu Mita

author
#0 lore raw

PATCH 1/3 powerpc: delete -mstring option

There is no reason to force -mstring option. (Kumar, please see patch 2/3 for FSL_BOOKE temporary fix)

Signed-off-by Akinobu Mita <[email protected]>
arch/powerpc/Makefile +0 -4
Index: 2.6-git-ps3/arch/powerpc/Makefile
===================================================================
@@ -102,10 +102,6 @@ CFLAGS += $(call cc-option,-mno-altivec)
 # kernel considerably.
 CFLAGS += $(call cc-option,-funit-at-a-time)
 
-ifndef CONFIG_FSL_BOOKE
-CFLAGS		+= -mstring
-endif
-
 ifeq ($(CONFIG_6xx),y)
 CFLAGS		+= -mcpu=powerpc
 endif
#1 lore raw

arch/powerpc/Makefile CFLAGS += $(call cc-option,-mno-altivec) · line 107

Quoted 6 lines

There is no reason to force -mstring option. (Kumar, please see patch 2/3 for FSL_BOOKE temporary fix)

arch/powerpc/Makefile +0 -3
-ifndef CONFIG_FSL_BOOKE
-CFLAGS		+= -mstring
-endif

[and from 2/3]

Review

Quoted 3 lines
(quoted diff) +3 -0
+ifeq ($(CONFIG_FSL_BOOKE),y)
+CFLAGS         += -mno-string
+endif

This is the right solution, thank you for the patch. But please fold these two together so that you're not introducing a regression halfway the patch series.

Segher

#2 lore raw
Quoted 9 lines · Segher Boessenkool

arch/powerpc/Makefile CFLAGS += $(call cc-option,-mno-altivec) · line 107

Quoted 6 lines

There is no reason to force -mstring option. (Kumar, please see patch 2/3 for FSL_BOOKE temporary fix)

arch/powerpc/Makefile +0 -3
-ifndef CONFIG_FSL_BOOKE
-CFLAGS		+= -mstring
-endif

[and from 2/3]

Quoted 7 lines

Review

Quoted 3 lines
(quoted diff) +3 -0
+ifeq ($(CONFIG_FSL_BOOKE),y)
+CFLAGS         += -mno-string
+endif

This is the right solution, thank you for the patch. But please fold these two together so that you're not introducing a regression halfway the patch series.

I agree this looks good and merge patches 1/3 and 2/3 into a single patch.

- k

author
#3 lore raw
Quoted 6 lines · Kumar Gala
Quoted 3 lines

This is the right solution, thank you for the patch. But please fold these two together so that you're not introducing a regression halfway the patch series.

I agree this looks good and merge patches 1/3 and 2/3 into a single patch.

Thansk, this is updated patch.

From: Akinobu Mita <[email protected]>
Subject: powerpc: delete -mstring option

There is no reason to force -mstring option.

This patch removes -mstring option, and adds -mno-string option for FLS_BOOKE (Because GCC is now putting string instructions even if you don't specify -mstring).

Signed-off-by Akinobu Mita <[email protected]>
---
 arch/powerpc/Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/Makefile +2 -2
Index: 2.6-git-ps3/arch/powerpc/Makefile
===================================================================
@@ -102,8 +102,8 @@ CFLAGS += $(call cc-option,-mno-altivec)
 # kernel considerably.
 CFLAGS += $(call cc-option,-funit-at-a-time)
 
-ifndef CONFIG_FSL_BOOKE
-CFLAGS		+= -mstring
+ifeq ($(CONFIG_FSL_BOOKE),y)
+CFLAGS         += -mno-string
 endif
 
 ifeq ($(CONFIG_6xx),y)