Skip to contentSkip to conversation

usbatm_heavy_init: don't use CLONE_SIGHAND

PATCH In review Oleg Nesterov 2 participants 2 messages Apr 12, 2007 – Apr 13, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usbatm_heavy_init: don't use CLONE_SIGHAND

usbatm_do_heavy_init() calls allow_signal() which plays with parent process's ->sighand.

drivers/usb/atm/usbatm.c renamed from drivers/usb/atm/usbatm.c~usbatm +1 -1
@@ -1019,7 +1019,7 @@ static int usbatm_do_heavy_init(void *ar
 
 static int usbatm_heavy_init(struct usbatm_data *instance)
 {
-	int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_KERNEL);
+	int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_FS | CLONE_FILES);
 
 	if (ret < 0) {
 		usb_err(instance, "%s: failed to create kernel_thread (%d)!\n", __func__, ret);
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Friday 13 April 2007 01:56:31 Oleg Nesterov wrote:

usbatm_do_heavy_init() calls allow_signal() which plays with parent process's ->sighand.

Quoted 13 lines
drivers/usb/atm/usbatm.c renamed from drivers/usb/atm/usbatm.c~usbatm +1 -1
@@ -1019,7 +1019,7 @@ static int usbatm_do_heavy_init(void *ar
 
 static int usbatm_heavy_init(struct usbatm_data *instance)
 {
-	int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_KERNEL);
+	int ret = kernel_thread(usbatm_do_heavy_init, instance, CLONE_FS | CLONE_FILES);
 
 	if (ret < 0) {
 		usb_err(instance, "%s: failed to create kernel_thread (%d)!\n", __func__, ret);