Skip to contentSkip to conversation

wait_for_helper: remove unneeded do_sigaction()

PATCH New Oleg Nesterov 1 participant 1 message Apr 13, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wait_for_helper: remove unneeded do_sigaction()

allow_signal(SIGCHLD) does all necessary job, no need to call do_sigaction() prior to.

kernel/kmod.c renamed from kernel/kmod.c~WH +0 -5
@@ -181,14 +181,9 @@ static int wait_for_helper(void *data)
 {
 	struct subprocess_info *sub_info = data;
 	pid_t pid;
-	struct k_sigaction sa;
 
 	/* Install a handler: if SIGCLD isn't handled sys_wait4 won't
 	 * populate the status, but will return -ECHILD. */
-	sa.sa.sa_handler = SIG_IGN;
-	sa.sa.sa_flags = 0;
-	siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD));
-	do_sigaction(SIGCHLD, &sa, NULL);
 	allow_signal(SIGCHLD);
 
 	pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD);