Skip to contentSkip to conversation

retry [PATCH] partition : add support for sysv68 partitions

PATCH New Philippe De Muyter 4 participants 8 messages Apr 13, 2007 – May 9, 2007

lore
Share & tools
lore
#0 lore raw

Hi all,

Add support for the Motorola sysv68 disk partition table (slices in motorola doc).

fs/partitions/Kconfig +9 -0
diff -r 1b54f1d81bc5 fs/partitions/Kconfig
@@ -236,3 +236,12 @@ config EFI_PARTITION
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using EFI GPT.
+
+config SYSV68_PARTITION
+	bool "SYSV68 partition table support" if PARTITION_ADVANCED
+	default y if M68K
+	help
+	  Say Y here if you would like to be able to read the hard disk
+	  partition table format used by Motorola Delta machines (using
+	  sysv68).
+	  Otherwise, say N.
fs/partitions/Makefile +1 -0
diff -r 1b54f1d81bc5 fs/partitions/Makefile
@@ -17,3 +17,4 @@ obj-$(CONFIG_IBM_PARTITION) += ibm.o
 obj-$(CONFIG_IBM_PARTITION) += ibm.o
 obj-$(CONFIG_EFI_PARTITION) += efi.o
 obj-$(CONFIG_KARMA_PARTITION) += karma.o
+obj-$(CONFIG_SYSV68_PARTITION) += sysv68.o
fs/partitions/check.c +4 -0
diff -r 1b54f1d81bc5 fs/partitions/check.c
@@ -34,6 +34,7 @@
 #include "ultrix.h"
 #include "efi.h"
 #include "karma.h"
+#include "sysv68.h"
 
 #ifdef CONFIG_BLK_DEV_MD
 extern void md_autodetect_dev(dev_t dev);
@@ -104,6 +105,9 @@ static int (*check_part[])(struct parsed
 #endif
 #ifdef CONFIG_KARMA_PARTITION
 	karma_partition,
+#endif
+#ifdef CONFIG_SYSV68_PARTITION
+	sysv68_partition,
 #endif
 	NULL
 };
fs/partitions/sysv68.c new file +92 -0

92 lines not on this page · raw message

fs/partitions/sysv68.h new file +1 -0
diff -r 1b54f1d81bc5 fs/partitions/sysv68.h
@@ -0,0 +1,1 @@
+extern int sysv68_partition(struct parsed_partitions *state, struct block_device *bdev);
#1 lore raw

Hi Philippe,

Quoted 9 lines · Philippe De Muyter

Add support for the Motorola sysv68 disk partition table (slices in motorola doc).

diff -r 1b54f1d81bc5 fs/partitions/Kconfig

fs/partitions/Kconfig config EFI_PARTITION · line 242

Quoted 7 lines
fs/partitions/Kconfig +4 -0
@@ -236,3 +236,12 @@ config EFI_PARTITION
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using EFI GPT.
+
+config SYSV68_PARTITION
+	bool "SYSV68 partition table support" if PARTITION_ADVANCED
+	default y if M68K
        ^^^^^^^^^^^^^^^^^

fs/partitions/Kconfig config EFI_PARTITION · line 247

Quoted 5 lines
fs/partitions/Kconfig +5 -0
+	help
+	  Say Y here if you would like to be able to read the hard disk
+	  partition table format used by Motorola Delta machines (using
+	  sysv68).
+	  Otherwise, say N.

Bummer, I saw your patch before, but I never noticed the `default y if M68K'.

Can you please tell me on which platforms SYSV68 partition tables are commonly used (I guess the Motorola MVME boards?), so we can enable it by default on a more sensible subset of M68K?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw

Hi Geert,

Quoted 28 lines · Geert Uytterhoeven

Hi Philippe,

Quoted 9 lines · Philippe De Muyter

Add support for the Motorola sysv68 disk partition table (slices in motorola doc).

diff -r 1b54f1d81bc5 fs/partitions/Kconfig

fs/partitions/Kconfig config EFI_PARTITION · line 242

Quoted 7 lines
fs/partitions/Kconfig +4 -0
@@ -236,3 +236,12 @@ config EFI_PARTITION
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using EFI GPT.
+
+config SYSV68_PARTITION
+	bool "SYSV68 partition table support" if PARTITION_ADVANCED
+	default y if M68K
        ^^^^^^^^^^^^^^^^^

fs/partitions/Kconfig config EFI_PARTITION · line 247

Quoted 5 lines
fs/partitions/Kconfig +5 -0
+	help
+	  Say Y here if you would like to be able to read the hard disk
+	  partition table format used by Motorola Delta machines (using
+	  sysv68).
+	  Otherwise, say N.

Bummer, I saw your patch before, but I never noticed the `default y if M68K'.

Quoted 2 lines

Can you please tell me on which platforms SYSV68 partition tables are commonly used (I guess the Motorola MVME boards?), so we can enable it by default on a

The Motorola VME boards are the only ones I am aware of. I must also add that the partitions themselves are sysv partitions.

Quoted 1 line

more sensible subset of M68K?

Feel free to replace or suppress the default' directive. I actually wrote that for a i586 laptop to access/reinstall disks of sysV68 machines using a USB/SCSI adapter, but I don't think default y' is a good idea :).

What do you think of
`default y if VME'
or

	`default y if M68K && SYSV_FS'

Best regards

Philippe

#3 lore raw
Quoted 35 lines · Philippe De Muyter
Quoted 26 lines · Geert Uytterhoeven
Quoted 9 lines · Philippe De Muyter

Add support for the Motorola sysv68 disk partition table (slices in motorola doc).

diff -r 1b54f1d81bc5 fs/partitions/Kconfig

fs/partitions/Kconfig config EFI_PARTITION · line 242

Quoted 7 lines
fs/partitions/Kconfig +4 -0
@@ -236,3 +236,12 @@ config EFI_PARTITION
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using EFI GPT.
+
+config SYSV68_PARTITION
+	bool "SYSV68 partition table support" if PARTITION_ADVANCED
+	default y if M68K
        ^^^^^^^^^^^^^^^^^

fs/partitions/Kconfig config EFI_PARTITION · line 247

Quoted 5 lines
fs/partitions/Kconfig +5 -0
+	help
+	  Say Y here if you would like to be able to read the hard disk
+	  partition table format used by Motorola Delta machines (using
+	  sysv68).
+	  Otherwise, say N.

Bummer, I saw your patch before, but I never noticed the `default y if M68K'.

Quoted 2 lines

Can you please tell me on which platforms SYSV68 partition tables are commonly used (I guess the Motorola MVME boards?), so we can enable it by default on a

The Motorola VME boards are the only ones I am aware of. I must also add that the partitions themselves are sysv partitions.

Quoted 1 line

more sensible subset of M68K?

Quoted 8 lines

Feel free to replace or suppress the default' directive. I actually wrote that for a i586 laptop to access/reinstall disks of sysV68 machines using a USB/SCSI adapter, but I don't think default y' is a good idea :).

What do you think of
`default y if VME'
or

	`default y if M68K && SYSV_FS'

I prefer `default y if VME'.

BTW, perhaps PPC based Motorola MVME boards use SYSV68 partition tables, too?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw

Hi Geert,

Quoted 9 lines
Quoted 4 lines

What do you think of
`default y if VME'
or

	`default y if M68K && SYSV_FS'

I prefer `default y if VME'.

BTW, perhaps PPC based Motorola MVME boards use SYSV68 partition tables, too?

No, the PPC based Motorola MVME boards use the (currently not supported by linux) AIX partition tables, as do also the motorola powerstack machines.

The m88k based Motorola MVME boards use the sysV68 partition tables, but m88k is not yet supported by linux.

Incidentally, what is the problem you have with SYSV68_PARTITION ? On my i586 machine, code size is 434 bytes for sysv68.o + 4 bytes more in check.c

Philippe

#5 lore raw
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
	`default y if M68K && SYSV_FS'

I prefer `default y if VME'.

Incidentally, what is the problem you have with SYSV68_PARTITION ? On my i586 machine, code size is 434 bytes for sysv68.o + 4 bytes more in check.c

Traditionally, we have always been very conservative about enabling more than the absolute minimum in partition format support. Some formats can be erroneously identified by the check code if you don't get the ordering right (the case I know about, MSDOS partitions vs. Atari TOS/GEM partitions, hinges on a particular checksum being calculated in the atari code). I've moved the msdos checker to the bottom of the list more often than I can keep track of...

If sysv68 cannot be confused with any other format, no harm done by enabling it by default. Otherwise, things may get interesting.

Michael

#6 lore raw
In reply to Geert Uytterhoeven
Quoted 27 lines · Geert Uytterhoeven

Hi Philippe,

Quoted 9 lines · Philippe De Muyter

Add support for the Motorola sysv68 disk partition table (slices in motorola doc).

diff -r 1b54f1d81bc5 fs/partitions/Kconfig

fs/partitions/Kconfig config EFI_PARTITION · line 242

Quoted 7 lines
fs/partitions/Kconfig +4 -0
@@ -236,3 +236,12 @@ config EFI_PARTITION
 	help
 	  Say Y here if you would like to use hard disks under Linux which
 	  were partitioned using EFI GPT.
+
+config SYSV68_PARTITION
+	bool "SYSV68 partition table support" if PARTITION_ADVANCED
+	default y if M68K
        ^^^^^^^^^^^^^^^^^

fs/partitions/Kconfig config EFI_PARTITION · line 247

Quoted 5 lines
fs/partitions/Kconfig +5 -0
+	help
+	  Say Y here if you would like to be able to read the hard disk
+	  partition table format used by Motorola Delta machines (using
+	  sysv68).
+	  Otherwise, say N.

Bummer, I saw your patch before, but I never noticed the `default y if M68K'.

Quoted 2 lines

Can you please tell me on which platforms SYSV68 partition tables are commonly used (I guess the Motorola MVME boards?),

I guess so. I have a disk for my MVME167 lying around here somewhere with SYSV/68 on it. If you want, I can verify what exact machines it runs on, but I guess "every 68k MVME" is a safe enough bet.

Signature · 3 lines
Shaw's Principle:
	Build a system that even a fool can use, and only a fool will
	want to use it.
#7 lore raw

PATCH 1/1 Let SYSV68_PARTITION default to yes on VME only

In reply to Geert Uytterhoeven

Don't enable SYSV68 partition table support on all m68k boxes by default, only on Motorola VME boards.

Cc Philippe De Muyter <[email protected]>
---
 fs/partitions/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/partitions/Kconfig +1 -1
@@ -239,7 +239,7 @@ config EFI_PARTITION
 
 config SYSV68_PARTITION
 	bool "SYSV68 partition table support" if PARTITION_ADVANCED
-	default y if M68K
+	default y if VME
 	help
 	  Say Y here if you would like to be able to read the hard disk
 	  partition table format used by Motorola Delta machines (using

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds