mod_sysfs_setup() doesn't return errno when kobject_add_dir() failure occurs

PATCH New Akinobu Mita 1 participant 1 message Apr 14, 2007

Share & tools

Akinobu Mita

author

2007-04-14 06:13 UTC #0 lore raw

PATCH 1/1 mod_sysfs_setup() doesn't return errno when kobject_add_dir() failure occurs

mod_sysfs_setup() doesn't return an errno when kobject_add_dir() for module "holders" directory fails. So caller of mod_sysfs_setup() will keep going and get oops.

Signed-off-by Akinobu Mita <[email protected]>

kernel/module.c +3 -1

Index: 2.6-mm/kernel/module.c
===================================================================
@@ -1423,8 +1423,10 @@ int mod_sysfs_setup(struct module *mod,
 		goto out;
 
 	mod->holders_dir = kobject_add_dir(&mod->mkobj.kobj, "holders");
-	if (!mod->holders_dir)
+	if (!mod->holders_dir) {
+		err = -ENOMEM;
 		goto out_unreg;
+	}
 
 	err = module_param_sysfs_setup(mod, kparam, num_params);
 	if (err)