VIDEO_FB_LITTLE_ENDIAN name confusion
PATCH 1/1 VIDEO_FB_LITTLE_ENDIAN name confusion
I've noticed that VIDEO_FB_LITTLE_ENDIAN in drivers/cfb_console.c is not really well named. What it does is swap bytes around if the frame buffer has a /different/ endianness from the host. If you start with a little endian host and frame buffer and define VIDEO_FB_LITTLE_ENDIAN the drawn colors get incorrectly byte swapped.
the attached patch changes VIDEO_FB_LITTLE_ENDIAN to VIDEO_FB_OTHER_ENDIAN to make it clearer what it does.
Signature · 9 lines
Hardware, n.:
The parts of a computer system that can be kicked.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-cfb-little-endian.patch
Type: text/x-diff
Size: 3101 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070416/bb4aa02c/attachment.patch PATCH 1/1 VIDEO_FB_LITTLE_ENDIAN name confusion
Quoted 5 lines · Andrew Dyer
I've noticed that
VIDEO_FB_LITTLE_ENDIANindrivers/cfb_console.cis not really well named. What it does is swap bytes around if the frame buffer has a /different/ endianness from the host. If you start with a little endian host and frame buffer and defineVIDEO_FB_LITTLE_ENDIANthe drawn colors get incorrectly byte swapped.
I think that the right thing to do is to avoid that the byte are swapped if the CPU and framebuffer endianess are the same.
However the patchg reduces possible misunderstanding...
Ciao,
Rodolfo
Signature · 4 lines
GNU/Linux Solutions e-mail: giometti at enneenne.com Linux Device Driver giometti at gnudd.com Embedded Systems giometti at linux.it UNIX programming phone: +39 349 2432127