Skip to contentSkip to conversation

rtl818x-mac80211: fix coding style

PATCH In review Stefano Brivio 2 participants 5 messages Apr 19, 2007 – Apr 20, 2007 Networking drivers (wireless)

lore
Share & tools
lore

Stefano Brivio

author
#0 lore raw

PATCH 1/1 rtl818x-mac80211: fix coding style

Fix coding style.

Signed-off-by Stefano Brivio <[email protected]>

---

drivers/net/wireless/mac80211/rtl818x/rtl8187.h +6 -6
Index: wireless-dev/drivers/net/wireless/mac80211/rtl818x/rtl8187.h
===================================================================
@@ -68,7 +68,7 @@ static inline u8 rtl818x_ioread8(struct 
 
 	usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
 			RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 
 	return val;
 }

@@ -79,7 +79,7 @@ static inline u8 rtl818x_ioread16(struct
 
 	usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
 			RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 
 	return le16_to_cpu(val);
 }

@@ -90,7 +90,7 @@ static inline u8 rtl818x_ioread32(struct
 
 	usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
 			RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 
 	return le32_to_cpu(val);
 }

@@ -100,7 +100,7 @@ static inline void rtl818x_iowrite8(stru
 {
 	usb_control_msg(priv->udev, usb_sndctrlpipe(priv->udev, 0),
 			RTL8187_REQ_SET_REG, RTL8187_REQT_WRITE,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 }
 
 static inline void rtl818x_iowrite16(struct rtl8187_priv *priv,

@@ -110,7 +110,7 @@ static inline void rtl818x_iowrite16(str
 
 	usb_control_msg(priv->udev, usb_sndctrlpipe(priv->udev, 0),
 			RTL8187_REQ_SET_REG, RTL8187_REQT_WRITE,
-			(unsigned long)addr, 0, &buf, sizeof(buf), HZ/2);
+			(unsigned long)addr, 0, &buf, sizeof(buf), HZ / 2);
 }
 
 static inline void rtl818x_iowrite32(struct rtl8187_priv *priv,

@@ -120,7 +120,7 @@ static inline void rtl818x_iowrite32(str
 
 	usb_control_msg(priv->udev, usb_sndctrlpipe(priv->udev, 0),
 			RTL8187_REQ_SET_REG, RTL8187_REQT_WRITE,
-			(unsigned long)addr, 0, &buf, sizeof(buf), HZ/2);
+			(unsigned long)addr, 0, &buf, sizeof(buf), HZ / 2);
 }
 
 #endif /* RTL8187_H */
drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c +36 -38

192 lines not on this page · raw message

drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c +33 -36

154 lines not on this page · raw message

drivers/net/wireless/mac80211/rtl818x/rtl818x.h +1 -1
Index: wireless-dev/drivers/net/wireless/mac80211/rtl818x/rtl818x.h
===================================================================
@@ -105,7 +105,7 @@ struct rtl818x_csr {
 	u8	reserved_17[32];
 	u16	TALLY_CNT;
 	u8	TALLY_SEL;
-} __attribute__ ((packed));
+} __attribute__((packed));
 
 static const struct ieee80211_rate rtl818x_rates[] = {
 	{ .rate = 10,
Signature · 2 lines
Ciao
Stefano
#1 lore raw
Quoted 2 lines · Stefano Brivio

Fix coding style.

Looks mostly good except for..

drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c static int rtl8187_init_hw(struct ieee80 · line 293

Quoted 2 lines
drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c +1 -1
-	// ehh?
+	// XXX: ehh?

Use FIXME if you want to put in a prefix.

drivers/net/wireless/mac80211/rtl818x/rtl818x.h struct rtl818x_csr { · line 108

Quoted 2 lines
drivers/net/wireless/mac80211/rtl818x/rtl818x.h +1 -1
-} __attribute__ ((packed));
+} __attribute__((packed));

I prefer the space here.

Thanks,
-Michael Wu

author
#2 lore raw
Quoted 8 lines · On Thu, 19 Apr 2007 19:23:26 -0400 Michael Wu <[email protected]> wrote:
Quoted 2 lines · Stefano Brivio

Fix coding style.

Looks mostly good except for..

drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c static int rtl8187_init_hw(struct ieee80 · line 293

Quoted 2 lines
drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c +1 -1
-	// ehh?
+	// XXX: ehh?

Use FIXME if you want to put in a prefix.

"XXX:" means we don't know if it's a FIXME, a TODO or just correct code. It's quite used. Unless this is a clear FIXME, I'd keep it.

Quoted 3 lines

drivers/net/wireless/mac80211/rtl818x/rtl818x.h struct rtl818x_csr { · line 108

Quoted 2 lines
drivers/net/wireless/mac80211/rtl818x/rtl818x.h +1 -1
-} __attribute__ ((packed));
+} __attribute__((packed));

I prefer the space here.

Please see CodingStyle.

Signature · 2 lines
Ciao
Stefano
#3 lore raw
Quoted 8 lines · Stefano Brivio

On Thu, 19 Apr 2007 19:23:26 -0400

Quoted 5 lines · Michael Wu
Quoted 1 line · Stefano Brivio

Fix coding style.

Looks mostly good except for..

Quoted 8 lines
Quoted 4 lines

drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c static int rtl8187_init_hw(struct ieee80 · line 293

Quoted 2 lines
drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c +1 -1
-	// ehh?
+	// XXX: ehh?

Use FIXME if you want to put in a prefix.

"XXX:" means we don't know if it's a FIXME, a TODO or just correct code. It's quite used. Unless this is a clear FIXME, I'd keep it.

Sure. But I don't use it in my drivers. Take it out if you don't like FIXME.

Quoted 6 lines
Quoted 4 lines

drivers/net/wireless/mac80211/rtl818x/rtl818x.h struct rtl818x_csr { · line 108

Quoted 2 lines
drivers/net/wireless/mac80211/rtl818x/rtl818x.h +1 -1
-} __attribute__ ((packed));
+} __attribute__((packed));

I prefer the space here.

Please see CodingStyle.

Fair enough.

Thanks,
-Michael Wu

author
#4 lore raw

PATCH 1/1 rtl818x-mac80211: fix coding style

Fix coding style.

Signed-off-by Stefano Brivio <[email protected]>

---

drivers/net/wireless/mac80211/rtl818x/rtl8187.h +6 -6
Index: wireless-dev/drivers/net/wireless/mac80211/rtl818x/rtl8187.h
===================================================================
@@ -68,7 +68,7 @@ static inline u8 rtl818x_ioread8(struct 
 
 	usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
 			RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 
 	return val;
 }

@@ -79,7 +79,7 @@ static inline u8 rtl818x_ioread16(struct
 
 	usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
 			RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 
 	return le16_to_cpu(val);
 }

@@ -90,7 +90,7 @@ static inline u8 rtl818x_ioread32(struct
 
 	usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
 			RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 
 	return le32_to_cpu(val);
 }

@@ -100,7 +100,7 @@ static inline void rtl818x_iowrite8(stru
 {
 	usb_control_msg(priv->udev, usb_sndctrlpipe(priv->udev, 0),
 			RTL8187_REQ_SET_REG, RTL8187_REQT_WRITE,
-			(unsigned long)addr, 0, &val, sizeof(val), HZ/2);
+			(unsigned long)addr, 0, &val, sizeof(val), HZ / 2);
 }
 
 static inline void rtl818x_iowrite16(struct rtl8187_priv *priv,

@@ -110,7 +110,7 @@ static inline void rtl818x_iowrite16(str
 
 	usb_control_msg(priv->udev, usb_sndctrlpipe(priv->udev, 0),
 			RTL8187_REQ_SET_REG, RTL8187_REQT_WRITE,
-			(unsigned long)addr, 0, &buf, sizeof(buf), HZ/2);
+			(unsigned long)addr, 0, &buf, sizeof(buf), HZ / 2);
 }
 
 static inline void rtl818x_iowrite32(struct rtl8187_priv *priv,

@@ -120,7 +120,7 @@ static inline void rtl818x_iowrite32(str
 
 	usb_control_msg(priv->udev, usb_sndctrlpipe(priv->udev, 0),
 			RTL8187_REQ_SET_REG, RTL8187_REQT_WRITE,
-			(unsigned long)addr, 0, &buf, sizeof(buf), HZ/2);
+			(unsigned long)addr, 0, &buf, sizeof(buf), HZ / 2);
 }
 
 #endif /* RTL8187_H */
drivers/net/wireless/mac80211/rtl818x/rtl8187_dev.c +36 -38

192 lines not on this page · raw message

drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c +33 -36

154 lines not on this page · raw message

drivers/net/wireless/mac80211/rtl818x/rtl818x.h +1 -1
Index: wireless-dev/drivers/net/wireless/mac80211/rtl818x/rtl818x.h
===================================================================
@@ -105,7 +105,7 @@ struct rtl818x_csr {
 	u8	reserved_17[32];
 	u16	TALLY_CNT;
 	u8	TALLY_SEL;
-} __attribute__ ((packed));
+} __attribute__((packed));
 
 static const struct ieee80211_rate rtl818x_rates[] = {
 	{ .rate = 10,