Kconfig: unwanted config options for s390.

PATCH In review Martin Schwidefsky 2 participants 3 messages Apr 20, 2007 – Apr 22, 2007

Subsystems (2)

s390 Char and misc drivers

lore

Share & tools

lore

Martin Schwidefsky

author

2007-04-20 11:32 UTC #0 lore raw

PATCH 3/8 Kconfig: unwanted config options for s390.

From: Martin Schwidefsky <[email protected]>

Disable all configuration options in the common Kconfig files that are of no interest to a s390 machine.

Signed-off-by Martin Schwidefsky <[email protected]>

---

 drivers/char/Kconfig |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

drivers/char/Kconfig +6 -3

diff -urpN linux-2.6/drivers/char/Kconfig linux-2.6-patched/drivers/char/Kconfig
@@ -6,6 +6,7 @@ menu "Character devices"
 
 config VT
 	bool "Virtual terminal" if EMBEDDED
+	depends on !S390
 	select INPUT
 	default y if !VIOCONS
 	---help---

@@ -81,6 +82,7 @@ config VT_HW_CONSOLE_BINDING
 
 config SERIAL_NONSTANDARD
 	bool "Non-standard serial port support"
+	depends on !S390
 	---help---
 	  Say Y here if you have any non-standard serial boards -- boards
 	  which aren't supported using the standard "dumb" serial driver.

@@ -774,7 +776,7 @@ config NVRAM
 
 config RTC
 	tristate "Enhanced Real Time Clock Support"
-	depends on !PPC && !PARISC && !IA64 && !M68K && (!SPARC || PCI) && !FRV && !ARM && !SUPERH
+	depends on !PPC && !PARISC && !IA64 && !M68K && (!SPARC || PCI) && !FRV && !ARM && !SUPERH && !S390
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you

@@ -822,7 +824,7 @@ config SGI_IP27_RTC
 
 config GEN_RTC
 	tristate "Generic /dev/rtc emulation"
-	depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV
+	depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV && !S390
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you

@@ -878,6 +880,7 @@ config DTLK
 
 config R3964
 	tristate "Siemens R3964 line discipline"
+	depends on !S390
 	---help---
 	  This driver allows synchronous communication with devices using the
 	  Siemens R3964 packet protocol. Unless you are dealing with special

@@ -1053,7 +1056,7 @@ config HPET_MMAP
 
 config HANGCHECK_TIMER
 	tristate "Hangcheck timer"
-	depends on X86 || IA64 || PPC64
+	depends on X86 || IA64 || PPC64 || S390
 	help
 	  The hangcheck-timer module detects when the system has gone
 	  out to lunch past a certain margin.  It can reboot the system

Arnd Bergmann

maintainer

2007-04-21 23:15 UTC #1 lore raw

drivers/char/Kconfig menu "Character devices" · line 12

Quoted 11 lines · Martin Schwidefsky

diff -urpN linux-2.6/drivers/char/Kconfig linux-2.6-patched/drivers/char/Kconfig
drivers/char/Kconfig +1 -0
@@ -6,6 +6,7 @@ menu "Character devices"
 
 config VT
 	bool "Virtual terminal" if EMBEDDED
+	depends on !S390
 	select INPUT
 	default y if !VIOCONS
 	---help---

drivers/char/Kconfig config VT_HW_CONSOLE_BINDING · line 88

Quoted 8 lines

drivers/char/Kconfig +1 -0

@@ -81,6 +82,7 @@ config VT_HW_CONSOLE_BINDING
 
 config SERIAL_NONSTANDARD
 	bool "Non-standard serial port support"
+	depends on !S390
 	---help---
 	  Say Y here if you have any non-standard serial boards -- boards
 	  which aren't supported using the standard "dumb" serial driver.

depends on MMIO

Quoted 10 lines

drivers/char/Kconfig +1 -1

@@ -774,7 +776,7 @@ config NVRAM
 
 config RTC
 	tristate "Enhanced Real Time Clock Support"
-	depends on !PPC && !PARISC && !IA64 && !M68K && (!SPARC || PCI) && !FRV && !ARM && !SUPERH
+	depends on !PPC && !PARISC && !IA64 && !M68K && (!SPARC || PCI) && !FRV && !ARM && !SUPERH && !S390
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you

drivers/char/Kconfig config SGI_IP27_RTC · line 830

Quoted 8 lines

drivers/char/Kconfig +1 -1

@@ -822,7 +824,7 @@ config SGI_IP27_RTC
 
 config GEN_RTC
 	tristate "Generic /dev/rtc emulation"
-	depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV
+	depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV && !S390
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you

ok.

this one is bad in general and should probably be a select from the architecture, but that should not stop you from adding another architecture...

drivers/char/Kconfig config DTLK · line 886

Quoted 8 lines

drivers/char/Kconfig +1 -0

@@ -878,6 +880,7 @@ config DTLK
 
 config R3964
 	tristate "Siemens R3964 line discipline"
+	depends on !S390
 	---help---
 	  This driver allows synchronous communication with devices using the
 	  Siemens R3964 packet protocol. Unless you are dealing with special

Does it build? I don't see a point disabling this one just because there are no users. Most architectures also don't have users for this one, but it doesn't hurt be able to build it using allyesconfig.

	Arnd <><

Martin Schwidefsky

author

2007-04-22 08:01 UTC #2 lore raw

Quoted 10 lines · Arnd Bergmann

drivers/char/Kconfig config VT_HW_CONSOLE_BINDING · line 88

Quoted 8 lines

drivers/char/Kconfig +1 -0

@@ -81,6 +82,7 @@ config VT_HW_CONSOLE_BINDING
 
 config SERIAL_NONSTANDARD
 	bool "Non-standard serial port support"
+	depends on !S390
 	---help---
 	  Say Y here if you have any non-standard serial boards -- boards
 	  which aren't supported using the standard "dumb" serial driver.

depends on MMIO

Depends on HAS_IOMEM.

Quoted 12 lines

drivers/char/Kconfig config SGI_IP27_RTC · line 830

Quoted 9 lines

drivers/char/Kconfig +1 -1

@@ -822,7 +824,7 @@ config SGI_IP27_RTC
 
 config GEN_RTC
 	tristate "Generic /dev/rtc emulation"
-	depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV
+	depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV && !S390
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you

ok.

Quoted 2 lines

this one is bad in general and should probably be a select from the architecture, but that should not stop you from adding another architecture...

The disable extension would help here, but I never got anywhere with it.

Quoted 12 lines

drivers/char/Kconfig config DTLK · line 886
Quoted 8 lines
drivers/char/Kconfig +1 -0
@@ -878,6 +880,7 @@ config DTLK
 
 config R3964
 	tristate "Siemens R3964 line discipline"
+	depends on !S390
 	---help---
 	  This driver allows synchronous communication with devices using the
 	  Siemens R3964 packet protocol. Unless you are dealing with special
Does it build? I don't see a point disabling this one just because there are no users. Most architectures also don't have users for this one, but it doesn't hurt be able to build it using allyesconfig.

I'll try to build it.

Signature · 8 lines

blue skies,              IBM Deutschland Entwicklung GmbH
   Martin                Vorsitzender des Aufsichtsrats: Johann Weihen
                         Geschäftsführung: Herbert Kircher
Martin Schwidefsky       Sitz der Gesellschaft: Böblingen
Linux on zSeries         Registergericht: Amtsgericht Stuttgart,
   Development           HRB 243294

"Reality continues to ruin my life." - Calvin.