Skip to contentSkip to conversation

ipmi: check, if default ports are accessible on PPC

PATCH In review Christian Krafft 3 participants 4 messages Feb 26, 2007 – Apr 20, 2007 3 messages not in the archive IPMI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20070223135859.62e19ca8@localhost

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 ipmi: check, if default ports are accessible on PPC

Subject: ipmi: check, if default ports are accessible on PPC

From: Christian Krafft <[email protected]>

ipmi_si_intf tries to access default ports, if no device could be found elsewhere. On PPC we have a function to check, if these legacy IO ports are accessible. This patch adds a check for these ports on PPC.
This patch fixes a breakage of IPMI module
on PPC machines without a BMC.

drivers/char/ipmi/ipmi_si_intf.c +5 -0
Index: linux/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
@@ -2580,6 +2580,11 @@ static __devinit void default_find_bmc(v
 		if (!info)
 			return;
 
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(ipmi_defaults[i].port))
+			continue;
+#endif
+
 		info->addr_source = NULL;
 
 		info->si_type = ipmi_defaults[i].type;
Signature · 13 lines
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Johann Weihen
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294
Acked-by on v1 1/1
#4 lore raw
Quoted 4 lines · Christian Krafft

Subject: ipmi: check, if default ports are accessible on PPC

From: Christian Krafft <[email protected]>

Quoted 8 lines

ipmi_si_intf tries to access default ports, if no device could be found elsewhere. On PPC we have a function to check, if these legacy IO ports are accessible. This patch adds a check for these ports on PPC.
This patch fixes a breakage of IPMI module
on PPC machines without a BMC.

Yep that fixes the problem on my machine.

cheers

Signature · 8 lines
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#5 lore raw
In reply to Christian Krafft
Quoted 6 lines · Christian Krafft

ipmi_si_intf tries to access default ports, if no device could be found elsewhere. On PPC we have a function to check, if these legacy IO ports are accessible. This patch adds a check for these ports on PPC.
This patch fixes a breakage of IPMI module
on PPC machines without a BMC.

This patch is a no-op even for IPMI capable systems. None of the platform check_legacy_ioport() functions check for port number 0xca2, 0xca9 or 0xe4.

What exactly did you test? Appearently not Linus tree.

#6 lore raw
Quoted 10 lines · Olaf Hering
Quoted 6 lines · Christian Krafft

ipmi_si_intf tries to access default ports, if no device could be found elsewhere. On PPC we have a function to check, if these legacy IO ports are accessible. This patch adds a check for these ports on PPC.
This patch fixes a breakage of IPMI module
on PPC machines without a BMC.

This patch is a no-op even for IPMI capable systems.

I missed the 'return 0;' in pSeries_check_legacy_ioport().