Kconfig: silicon backplane dependency.
Subsystems (2)
PATCH 7/8 Kconfig: silicon backplane dependency.
From: Martin Schwidefsky <[email protected]>
Make the "Sonics Silicon Backplane" menu dependent on the two buses it can be found on.
Goes on top of git-wireless.patch.
---
drivers/ssb/Kconfig | 1 + 1 files changed, 1 insertion(+)
drivers/ssb/Kconfig +1 -0
@@ -1,4 +1,5 @@ menu "Sonics Silicon Backplane" + depends on PCI || PCMCIA config SSB tristate "Sonics Silicon Backplane support"
Quoted 18 lines · Martin Schwidefsky
From: Martin Schwidefsky <[email protected]>
Make the "Sonics Silicon Backplane" menu dependent on the two buses it can be found on.
Goes on top of git-wireless.patch.Cc Michael Buesch <[email protected]>Cc John W. Linville <[email protected]>Signed-off-by Martin Schwidefsky <[email protected]>---
drivers/ssb/Kconfig | 1 + 1 files changed, 1 insertion(+)diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig
drivers/ssb/Kconfig line 2
Quoted 2 lines
drivers/ssb/Kconfig +1
-0@@ -1,4 +1,5 @@ menu "Sonics Silicon Backplane" + depends on PCI || PCMCIA
This is wrong. SSB does not depend on PCI or PCMCIA. SSB can (and does) stay very well on its own feet and can be the main system bus.
Most Linksys WRT routers work that way. They have no PCI bus, but a SSB bus instead.
Nevertheless, I'm not sure what your problem really is. Does a s390 machine exist with a B44 card? I doubt it. So what about the following: We simply add
a DEPENDS ON !S390 to both SSB and B44.
I really thing that is the right fix for this. The patch above is clearly not, as it breaks things for embedded devices without PCI or PCMCIA bus.
Signature · 1 line
Greetings Michael.
Quoted 6 lines · Michael Buesch
This is wrong. SSB does not depend on PCI or PCMCIA. SSB can (and does) stay very well on its own feet and can be the main system bus.
Most Linksys WRT routers work that way. They have no PCI bus, but a SSB bus instead.
Quoted 7 lines
Nevertheless, I'm not sure what your problem really is. Does a s390 machine exist with a B44 card? I doubt it. So what about the following: We simply add
a DEPENDS ON !S390 to both SSB and B44.
I really thing that is the right fix for this. The patch above is clearly not, as it breaks things for embedded devices without PCI or PCMCIA bus.
Ok, thanks. I will change the patch accordingly.
Signature · 8 lines
blue skies, IBM Deutschland Entwicklung GmbH
Martin Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Martin Schwidefsky Sitz der Gesellschaft: Böblingen
Linux on zSeries Registergericht: Amtsgericht Stuttgart,
Development HRB 243294
"Reality continues to ruin my life." - Calvin.Quoted 19 lines · Martin Schwidefsky
From: Martin Schwidefsky <[email protected]>
Make the "Sonics Silicon Backplane" menu dependent on the two buses it can be found on.
Goes on top of git-wireless.patch.Cc Michael Buesch <[email protected]>Cc John W. Linville <[email protected]>Signed-off-by Martin Schwidefsky <[email protected]>---
drivers/ssb/Kconfig | 1 +
1 files changed, 1 insertion(+)diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig
drivers/ssb/Kconfig 2007-04-19 15:55:44.000000000 +0200 renamed from drivers/ssb/Kconfig 2007-04-19 15:24:40.000000000 +0200 +0
-0@@ -1,4 +1,5 @@
Quoted 2 lines
menu "Sonics Silicon Backplane"
+ depends on PCI || PCMCIA
No, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices.
I'd make this 'depends on MMIO' as well if you add that option.
Arnd <><
Quoted 9 lines · Arnd Bergmann
drivers/ssb/Kconfig 2007-04-19 15:55:44.000000000 +0200 line 2
Quoted 6 lines
diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig
drivers/ssb/Kconfig 2007-04-19 15:55:44.000000000 +0200 renamed from drivers/ssb/Kconfig 2007-04-19 15:24:40.000000000 +0200 +1
-0@@ -1,4 +1,5 @@ menu "Sonics Silicon Backplane" + depends on PCI || PCMCIANo, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices.
Yes, Michael already told me about that. The current solution is to use !S390, could we use HAS_IOMEM instead ?
Signature · 8 lines
blue skies, IBM Deutschland Entwicklung GmbH
Martin Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Martin Schwidefsky Sitz der Gesellschaft: Böblingen
Linux on zSeries Registergericht: Amtsgericht Stuttgart,
Development HRB 243294
"Reality continues to ruin my life." - Calvin.Quoted 11 lines · Martin Schwidefsky
Quoted 9 lines · Arnd Bergmann
drivers/ssb/Kconfig 2007-04-19 15:55:44.000000000 +0200 line 2
Quoted 6 lines
diff -urpN linux-2.6/drivers/ssb/Kconfig linux-2.6-patched/drivers/ssb/Kconfig
drivers/ssb/Kconfig 2007-04-19 15:55:44.000000000 +0200 renamed from drivers/ssb/Kconfig 2007-04-19 15:24:40.000000000 +0200 +1
-0@@ -1,4 +1,5 @@ menu "Sonics Silicon Backplane" + depends on PCI || PCMCIANo, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices.
Quoted 2 lines
Yes, Michael already told me about that. The current solution is to use !S390, could we use
HAS_IOMEMinstead ?
I'd think either should be fine.
Signature · 1 line
Greetings Michael.
Quoted 7 lines · Michael Buesch
Quoted 5 lines
Quoted 2 lines
No, this doesn't look right. There are other devices that come with SiliconBackplane but are not PCI or PCMCIA style devices.
Yes, Michael already told me about that. The current solution is to use !S390, could we use
HAS_IOMEMinstead ?I'd think either should be fine.
I will use HAS_IOMEM then. The oddity with the select statement still exists though. I have to add the "depends on HAS_IOMEM" to SSB and B44. If I just add it to SSB then the config option for B44 exists for s390 and you can enable it. The select statement will then enable SSB as well (.config contains CONFIG_SSB=y for allyesconfig). This is in contradiction to the depends statement since HAS_IOMEM=n on s390.
The current Kconfig code does not check all select statements if they can be enabled before allowing the config option that does the select. So the rule for using select statements is that the depends line of the config option that selects another config option needs to be at least as restrictive as the depends line of the selected option. Hence I'll add the HAS_IOMEM depends to B44 as well. Okay ?
Signature · 8 lines
blue skies, IBM Deutschland Entwicklung GmbH
Martin Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Martin Schwidefsky Sitz der Gesellschaft: Böblingen
Linux on zSeries Registergericht: Amtsgericht Stuttgart,
Development HRB 243294
"Reality continues to ruin my life." - Calvin.Quoted 6 lines · Martin Schwidefsky
The current
Kconfigcode does not check all select statements if they can be enabled before allowing the config option that does the select. So the rule for using select statements is that the depends line of the config option that selects another config option needs to be at least as restrictive as the depends line of the selected option. Hence I'll add theHAS_IOMEMdepends to B44 as well. Okay ?
Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390?
Arnd <><
Quoted 9 lines · Arnd Bergmann
Quoted 6 lines
The current
Kconfigcode does not check all select statements if they can be enabled before allowing the config option that does the select. So the rule for using select statements is that the depends line of the config option that selects another config option needs to be at least as restrictive as the depends line of the selected option. Hence I'll add theHAS_IOMEMdepends to B44 as well. Okay ?Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390?
No, the option can be found in drivers/net/Kconfig under menu "Ethernet (10 or 100Mbit)".
Signature · 8 lines
blue skies, IBM Deutschland Entwicklung GmbH
Martin Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Martin Schwidefsky Sitz der Gesellschaft: Böblingen
Linux on zSeries Registergericht: Amtsgericht Stuttgart,
Development HRB 243294
"Reality continues to ruin my life." - Calvin.Quoted 6 lines · Martin Schwidefsky
Quoted 3 lines
Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390?
No, the option can be found in
drivers/net/Kconfigunder menu "Ethernet (10 or 100Mbit)".
Ah, I was confusing it with b43.
Depends on HAS_IOMEM sounds good then. I'd prefer to make it 'depends on SSB' instead of 'select SSB', but I don't want to get into that argument ;-)
Arnd <><
Quoted 5 lines · Arnd Bergmann
Quoted 4 lines · Martin Schwidefsky
Quoted 3 lines
Isn't B44 already behind a WIRELESS or IEEE80211 or similar option that can't be selected on s390?
Quoted 8 lines
Quoted 2 lines
No, the option can be found in
drivers/net/Kconfigunder menu "Ethernet (10 or 100Mbit)".Ah, I was confusing it with b43.
Depends on
HAS_IOMEMsounds good then. I'd prefer to make it 'depends on SSB' instead of 'select SSB', but I don't want to get into that argument ;-)
No, don't.
Add depends on to SSB and B44.
Signature · 1 line
Greetings Michael.