Battery class, external power framework, ds2760 battery
Subsystems (3)
cover Battery class, external power framework, ds2760 battery
Hi all,
I believe most battery issues elaborated and settled, and battery class has grown up for the -mm merge. Also, I hope that current battery stuff will make everyone happy at some grade.
This patchset accumulated ideas and suggestions from reviews by David Brownell, Evgeniy Polyakov, Greg KH, Henrique de Moraes Holschuh, Ian Molton, Matt Reimer, Matthew Garrett, Ondrej Zajicek, Paul Sokolovsky, Pavel Machek, Randy Dunlap, Russell King and Shem Multinymous.
Thanks for the time you spent reviewing these patches!
Quoted 9 lines · Pavel Machek
Quoted 9 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Anton Vorontsov <[email protected]>Yes please. Generic battery support is badly needed.
I'm glad you like it, thanks for the review!
Also I've done some code split. It removes all #ifdefs from
battery.c, and also separates core from sysfs and leds.
Quoted 7 lines
Quoted 2 lines
If there will no objections, I'll send this version when patch window will opened.
Actually, you probably want to add some changelogs, and send it to akpm _now_. He'll merge it to -mm tree, and hopefully send it upstream in the next window. Merging directly to linus is for bigger projects with git trees etc.
Andrew, would you please merge these patches into -mm? They're against today's Linus git tree.
I hope it isn't too late for the merge. If it is, please tell me when I should come back.
References:
http://lkml.org/lkml/2007/4/11/392
http://lkml.org/lkml/2007/4/11/393
http://lkml.org/lkml/2007/4/11/397
http://lkml.org/lkml/2007/4/11/398
http://lkml.org/lkml/2007/4/20/154
Thanks,
Signature · 4 lines
Anton Vorontsov email: [email protected] backup email: [email protected] irc://irc.freenode.org/bd2
PATCH 1/7 External power framework
Power supplies and power supplicants.
Supplicants (batteries so far) may ask to notify they when power supply arrive/gone. This framework used by battery class.
It's permitted for supply to be bound to several supplicants (think main and backup batteries).
It's also permitted for supplicants to consume power from several external supplies (say AC and USB).
Here is how it look like from userspace:
# pwd
/sys/class/power_supply
# ls
ac usb
# cat ac/online usb/online
1
0--- drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/power/Kconfig | 13 ++ drivers/power/Makefile | 1 + drivers/power/external_power.c | 361 ++++++++++++++++++++++++++++++++++++++++ include/linux/external_power.h | 56 ++++++ 6 files changed, 434 insertions(+), 0 deletions(-) create mode 100644 drivers/power/Kconfig create mode 100644 drivers/power/Makefile create mode 100644 drivers/power/external_power.c create mode 100644 include/linux/external_power.h
drivers/Kconfig +2 -0
@@ -54,6 +54,8 @@ source "drivers/spi/Kconfig" source "drivers/w1/Kconfig" +source "drivers/power/Kconfig" + source "drivers/hwmon/Kconfig" source "drivers/mfd/Kconfig"
drivers/Makefile +1 -0
@@ -60,6 +60,7 @@ obj-$(CONFIG_I2O) += message/ obj-$(CONFIG_RTC_LIB) += rtc/ obj-$(CONFIG_I2C) += i2c/ obj-$(CONFIG_W1) += w1/ +obj-$(CONFIG_EXTERNAL_POWER) += power/ obj-$(CONFIG_HWMON) += hwmon/ obj-$(CONFIG_PHONE) += telephony/ obj-$(CONFIG_MD) += md/
drivers/power/Kconfig new file +13 -0
@@ -0,0 +1,13 @@ + +menu "External power support" + +config EXTERNAL_POWER + tristate "External power kernel interface" + help + Say Y here to enable kernel external power detection interface, + like AC or USB. Information also will exported to userspace via + /sys/class/external_power/ directory. + + This interface is mandatory for battery class support. + +endmenu
drivers/power/Makefile new file +1 -0
@@ -0,0 +1 @@ +obj-$(CONFIG_EXTERNAL_POWER) += external_power.o
drivers/power/external_power.c new file +361 -0
361 lines not on this page · raw message
include/linux/external_power.h new file +56 -0
56 lines not on this page · raw message
Signature · 1 line
1.5.1.1-dirty
PATCH 2/7 pda power driver
In reply to Anton VorontsovCommon power driver for PDAs and phones with one or two external power supplies (AC/USB) connected to main and backup batteries, and optional builtin charger.
It's used to stop logic duplication through different embedded devices. So, power supply *logic* is here. pda_power register power supplies, and will take care about notifying batteries about power changes through external power interface.
AC/USB power consumption issues should be handled by platform code, inside set_charge function.
--- drivers/power/Kconfig | 8 ++ drivers/power/Makefile | 1 + drivers/power/pda_power.c | 239 +++++++++++++++++++++++++++++++++++++++++++++ include/linux/pda_power.h | 28 +++++ 4 files changed, 276 insertions(+), 0 deletions(-) create mode 100644 drivers/power/pda_power.c create mode 100644 include/linux/pda_power.h
drivers/power/Kconfig +8 -0
@@ -10,4 +10,12 @@ config EXTERNAL_POWER This interface is mandatory for battery class support. +config PDA_POWER + tristate "Generic PDA/phone power driver" + depends on EXTERNAL_POWER + help + Say Y here to enable generic power driver for PDAs and phones with + one or two external power supplies (AC/USB) connected to main and + backup batteries, and optional builtin charger. + endmenu
drivers/power/Makefile +1 -0
@@ -1 +1,2 @@ obj-$(CONFIG_EXTERNAL_POWER) += external_power.o +obj-$(CONFIG_PDA_POWER) += pda_power.o
drivers/power/pda_power.c new file +239 -0
239 lines not on this page · raw message
include/linux/pda_power.h new file +28 -0
@@ -0,0 +1,28 @@ +/* +* Common power driver for PDAs and phones with one or two external +* power supplies (AC/USB) connected to main and backup batteries, +* and optional builtin charger. +* +* Copyright 2007 Anton Vorontsov <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +#ifndef __PDA_POWER_H__ +#define __PDA_POWER_H__ + +#define PDA_POWER_CHARGE_AC (1 << 0) +#define PDA_POWER_CHARGE_USB (1 << 1) + +struct pda_power_pdata { +int (*is_ac_online)(void ); +int (*is_usb_online)(void ); +void (*set_charge)(int flags); + +unsigned int wait_for_status;/* msecs, default is 500 */ +unsigned int wait_for_charger;/* msecs, default is 500 */ +}; + +#endif /* __PDA_POWER_H__ */
Signature · 1 line
1.5.1.1-dirty
PATCH 3/7 Universal battery class
In reply to Anton VorontsovBattery class used to export battery properties to userspace in consistent manner.
It defines core set of battery attributes, available via sysfs, which should be applicable to (almost) every battery out there. Each attribute has well defined meaning, up to unit of measure used. While the attributes provided are believed to be universally applicable to any battery, specific monitoring hardware may not be able to provide them all, so any of them may be skipped.
Battery class is extensible, and allows to define drivers own attributes. The core attribute set is subject to the standard Linux evolution (i.e. if it will be found that some attribute is applicable to many batteries or their drivers, it can be added to the core set).
Battery class integrates with External Power framework, for the purpose of notification battery drivers when charging power is available. Note that specific charge control is left to the battery drivers.
It also integrates with LED framework, for the purpose of providing typically expected (at least for portable devices) feedback of battery status (charging/fully charged) via LEDs. (Note that specific details of the indication (including whether to use it at all) are fully controllable by user and/or specific machine defaults, per design principles of LED framework).
--- Documentation/battery-class.txt | 150 +++++++++++++++++++++++++++++++++++++++ drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/battery/Kconfig | 12 +++ drivers/battery/Makefile | 9 +++ drivers/battery/battery.c | 138 +++++++++++++++++++++++++++++++++++ drivers/battery/battery.h | 37 ++++++++++ drivers/battery/battery_leds.c | 106 +++++++++++++++++++++++++++ drivers/battery/battery_sysfs.c | 122 +++++++++++++++++++++++++++++++ include/linux/battery.h | 127 +++++++++++++++++++++++++++++++++ 10 files changed, 704 insertions(+), 0 deletions(-) create mode 100644 Documentation/battery-class.txt create mode 100644 drivers/battery/Kconfig create mode 100644 drivers/battery/Makefile create mode 100644 drivers/battery/battery.c create mode 100644 drivers/battery/battery.h create mode 100644 drivers/battery/battery_leds.c create mode 100644 drivers/battery/battery_sysfs.c create mode 100644 include/linux/battery.h
Documentation/battery-class.txt new file +150 -0
@@ -0,0 +1,150 @@ +Linux battery class +=================== + +Synopsis +~~~~~~~~ +Battery class used to export battery properties to userspace in consistent +manner. + +It defines core set of battery attributes, available via sysfs, which +should be applicable to (almost) every battery out there. Each attribute +has well defined meaning, up to unit of measure used. While the attributes +provided are believed to be universally applicable to any battery, +specific monitoring hardware may not be able to provide them all, so +any of them may be skipped. + +Battery class is extensible, and allows to define drivers own attributes. +The core attribute set is subject to the standard Linux evolution (i.e. +if it will be found that some attribute is applicable to many batteries +or their drivers, it can be added to the core set). + +Battery class integrates with External Power framework, for the purpose of +notification battery drivers when charging power is available. Note that +specific charge control is left to the battery drivers. + +It also integrates with LED framework, for the purpose of providing +typically expected (at least for portable devices) feedback of battery +status (charging/fully charged) via LEDs. (Note that specific details of +the indication (including whether to use it at all) are fully controllable +by user and/or specific machine defaults, per design principles of LED +framework). + + +Attributes/properties +~~~~~~~~~~~~~~~~~~~~~ +Battery class has predefined set of attributes, this eliminates code +duplication across battery drivers. Battery class insist on reusing its +predefined attributes *and* their units. + +So, userspace gets expected set of attributes and their units for +any kind of battery, and can process/present them to a user in consistent +manner. Results for different batteries and machines are also directly +comparable. + +See drivers/battery/ds2760_battery.c for the example how to declare and +handle attributes. + + +Units +~~~~~ +Quoting include/linux/battery.h: + + All voltages, currents, charges, energies, time and temperatures in uV, + uA, uAh, uWh, seconds and tenths of degree Celsius unless otherwise + stated. It's driver's job to convert its raw values to units in which + this class operates. + + +Attributes/properties detailed +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +~ ~ ~ ~ ~ ~ ~ Charge/Energy/Capacity - how to not confuse ~ ~ ~ ~ ~ ~ ~ +~ ~ +~ Because both "charge" (uAh) and "energy" (uWh) represents "capacity" ~ +~ of battery, battery class distinguish these terms. Don't mix them! ~ +~ ~ +~ CHARGE_* attributes represents capacity in uAh only. ~ +~ ENERGY_* attributes represents capacity in uWh only. ~ +~ CAPACITY attribute represents capacity in *percents*, from 0 to 100. ~ +~ ~ +~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ + +Postfixes: +_AVG - *hardware* averaged value, use it if your hardware is really able to +report averaged values. +_NOW - momentary/instantaneous values. + +STATUS - this attribute represents operating status (charging, full, +discharging (i.e. powering a load), etc.). This corresponds to +BATTERY_STATUS_* values, as defined in battery.h. + +HEALTH - represents health of the battery, values corresponds to +BATTERY_HEALTH_*, defined in battery.h. + +VOLTAGE_MAX_DESIGN, VOLTAGE_MIN_DESIGN - design values for maximal and +minimal battery voltages. Maximal/minimal means values of voltages when +battery considered "full"/"empty" at normal conditions. Yes, there is +no direct relation between voltage and battery capacity, but some dumb +batteries use voltage for very approximated calculation of capacity. +Battery driver also can use this attribute just to inform userspace +about maximal and minimal voltage thresholds of a given battery. + +CHARGE_FULL_DESIGN, CHARGE_EMPTY_DESIGN - design charge values, when +battery considered full/empty. + +ENERGY_FULL_DESIGN, ENERGY_EMPTY_DESIGN - same as above but for energy. + +CHARGE_FULL, CHARGE_EMPTY - These attributes means "last remembered value +of charge when battery became full/empty". It also could mean "value of +charge when battery considered full/empty at given conditions (temperature, +age)". I.e. these attributes represents real thresholds, not design values. + +ENERGY_FULL, ENERGY_EMPTY - same as above but for energy. + +CAPACITY - capacity in percents. + +TEMP - temperature of the battery. + +TIME_TO_EMPTY - seconds left for battery to be considered empty (i.e. +while battery powers a load) +TIME_TO_FULL - seconds left for battery to be considered full (i.e. +while battery is charging) + + +QA +~~ +Q: Where is BATTERY_PROP_XYZ attribute? +A: If you cannot find attribute suitable for your battery needs, feel free + to add it and send patch along with your battery driver. + + The attributes available currently are the ones currently provided by the + drivers written. + + Good candidates to add in future: battery technology, model/part#, + cycle_time, manufacturer, etc. + + +Q: I have some very specific attribute (e.g. battery color), should I add + this attribute to standard ones? +A: Most likely, no. Such attribute can be placed in the driver itself, if + it is useful. Of course, if the attribute in question applicable to + large set of batteries, provided by many drivers, and/or comes from + some general battery specification/standard, it may be a candidate to + be added to the core attribute set. + + +Q: Suppose, my battery monitoring chip/firmware does not provides capacity + in percents, but provides charge_{now,full,empty}. Should I calculate + percentage capacity manually, inside the driver, and register CAPACITY + attribute? The same question about time_to_empty/time_to_full. +A: Most likely, no. Battery class is designed to export battery properties + which are directly measurable by the specific hardware available. + Inferring not available properties using some heuristics or mathematical + model is not subject of work for a battery driver. Such functionality + should be factored out, and in fact, apm_power, the driver to serve + legacy APM API on top of battery class, uses a simple heuristic of + approximating remaining battery capacity based on its charge, current, + voltage and so on. But full-fledged battery model is likely not subject + for kernel at all, as it would require floating point calculation to deal + with things like differential equations and Kalman filters. This is + better be handled by batteryd/libbattery, yet to be written.
drivers/Kconfig +2 -0
@@ -56,6 +56,8 @@ source "drivers/w1/Kconfig" source "drivers/power/Kconfig" +source "drivers/battery/Kconfig" + source "drivers/hwmon/Kconfig" source "drivers/mfd/Kconfig"
drivers/Makefile +1 -0
@@ -61,6 +61,7 @@ obj-$(CONFIG_RTC_LIB) += rtc/ obj-$(CONFIG_I2C) += i2c/ obj-$(CONFIG_W1) += w1/ obj-$(CONFIG_EXTERNAL_POWER) += power/ +obj-$(CONFIG_BATTERY) += battery/ obj-$(CONFIG_HWMON) += hwmon/ obj-$(CONFIG_PHONE) += telephony/ obj-$(CONFIG_MD) += md/
drivers/battery/Kconfig new file +12 -0
@@ -0,0 +1,12 @@ + +menu "Battery devices" + +config BATTERY + tristate "Battery class support" + select EXTERNAL_POWER + help + Say Y here to enable battery class support. This allows battery + monitoring by userspace via sysfs (if available) and/or APM + kernel interface (if selected below). + +endmenu
drivers/battery/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +obj-$(CONFIG_BATTERY) += battery.o + +ifeq ($(CONFIG_SYSFS),y) +obj-$(CONFIG_BATTERY) += battery_sysfs.o +endif + +ifeq ($(CONFIG_LEDS_TRIGGERS),y) +obj-$(CONFIG_BATTERY) += battery_leds.o +endif
drivers/battery/battery.c new file +138 -0
138 lines not on this page · raw message
drivers/battery/battery.h new file +37 -0
@@ -0,0 +1,37 @@ +/* +* Functions private to battery.c +* +* Copyright (c) 2007 Anton Vorontsov <[email protected]> +* Copyright (c) 2004 Szabolcs Gyurko +* Copyright (c) 2003 Ian Molton <[email protected]> +* +* Modified: 2004, Oct Szabolcs Gyurko +* +* You may use this code as per GPL version 2 +*/ + +#ifdef CONFIG_SYSFS + +extern int battery_create_attrs (struct battery *bat); +extern void battery_remove_attrs (struct battery *bat); + +#else + +static inline int battery_create_attrs (struct battery *bat) {return 0 ; } +static inline void battery_remove_attrs (struct battery *bat) {} + +#endif /* CONFIG_SYSFS */ + +#ifdef CONFIG_LEDS_TRIGGERS + +extern void battery_update_leds (struct battery *bat,int status); +extern int battery_create_triggers (struct battery *bat); +extern void battery_remove_triggers (struct battery *bat); + +#else + +static inline void battery_update_leds (struct battery *bat,int status) {} +static inline int battery_create_triggers (struct battery *bat) {return 0 ; } +static inline void battery_remove_triggers (struct battery *bat) {} + +#endif /* CONFIG_LEDS_TRIGGERS */
drivers/battery/battery_leds.c new file +106 -0
106 lines not on this page · raw message
drivers/battery/battery_sysfs.c new file +122 -0
122 lines not on this page · raw message
include/linux/battery.h new file +127 -0
127 lines not on this page · raw message
Signature · 1 line
1.5.1.1-dirty
PATCH 4/7 APM emulation driver for class batteries
In reply to Anton Vorontsov--- drivers/battery/Kconfig | 7 ++ drivers/battery/Makefile | 2 + drivers/battery/apm_power.c | 228 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 237 insertions(+), 0 deletions(-) create mode 100644 drivers/battery/apm_power.c
drivers/battery/Kconfig +7 -0
@@ -9,4 +9,11 @@ config BATTERY monitoring by userspace via sysfs (if available) and/or APM kernel interface (if selected below). +config APM_POWER + tristate "APM emulation for class batteries" + depends on BATTERY && APM_EMULATION + help + Say Y here to enable support APM status emulation using + battery class devices. + endmenu
drivers/battery/Makefile +2 -0
@@ -7,3 +7,5 @@ endif ifeq ($(CONFIG_LEDS_TRIGGERS),y) obj-$(CONFIG_BATTERY) += battery_leds.o endif + +obj-$(CONFIG_APM_POWER) += apm_power.o
drivers/battery/apm_power.c new file +228 -0
228 lines not on this page · raw message
Signature · 1 line
1.5.1.1-dirty
PATCH 5/7 1-Wire ds2760 chip battery driver
In reply to Anton VorontsovThis is driver for batteries with ds2760 chip inside, found inside almost every HP iPaq and HTC PDAs/phones.
--- drivers/battery/Kconfig | 7 + drivers/battery/Makefile | 2 + drivers/battery/ds2760_battery.c | 503 ++++++++++++++++++++++++++++++++++++++ include/linux/ds2760_battery.h | 32 +++ 4 files changed, 544 insertions(+), 0 deletions(-) create mode 100644 drivers/battery/ds2760_battery.c create mode 100644 include/linux/ds2760_battery.h
drivers/battery/Kconfig +7 -0
@@ -16,4 +16,11 @@ config APM_POWER Say Y here to enable support APM status emulation using battery class devices. +config BATTERY_DS2760 + tristate "DS2760 battery driver (HP iPAQ & others)" + depends on BATTERY && W1 + select W1_SLAVE_DS2760 + help + Say Y here to enable support for batteries with ds2760 chip. + endmenu
drivers/battery/Makefile +2 -0
@@ -9,3 +9,5 @@ obj-$(CONFIG_BATTERY) += battery_leds.o endif obj-$(CONFIG_APM_POWER) += apm_power.o + +obj-$(CONFIG_BATTERY_DS2760) += ds2760_battery.o
drivers/battery/ds2760_battery.c new file +503 -0
503 lines not on this page · raw message
include/linux/ds2760_battery.h new file +32 -0
@@ -0,0 +1,32 @@ +/* +* Driver for batteries with DS2760 chips inside. +* +* Copyright (c) 2007 Anton Vorontsov +* 2004-2007 Matt Reimer +* 2004 Szabolcs Gyurko +* +* Use consistent with the GNU GPL is permitted, +* provided that this copyright notice is +* preserved in its entirety in all copies and derived works. +* +* Author: Anton Vorontsov <[email protected]> +* February 2007 +* +* Matt Reimer <[email protected]> +* April 2004, 2005, 2007 +* +* Szabolcs Gyurko <[email protected]> +* September 2004 +*/ + +#ifndef __DS2760_BATTERY__ +#define __DS2760_BATTERY__ + +#include <linux/battery.h> + +struct ds2760_platform_data { +/* Battery information and characteristics. */ +struct battery_info battery_info; +}; + +#endif
Signature · 1 line
1.5.1.1-dirty
PATCH 6/7 remove "#if 0" from find_bus function, export it.
In reply to Anton VorontsovThis function were placed in "#if 0" because nobody was using it. We using it now.
See http://lwn.net/Articles/210610/
--- drivers/base/bus.c | 5 ++--- include/linux/device.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/base/bus.c +2 -3
@@ -667,14 +667,13 @@ void put_bus(struct bus_type * bus)* * Note that kset_find_obj increments bus' reference count. */ -#if 0 +struct bus_type *find_bus (char * name) {struct kobject * k =kset_find_obj (&bus_subsys.kset, name);return k ?to_bus (k) :NULL ; } -#endif /* 0 */ - +EXPORT_SYMBOL_GPL (find_bus);/** * bus_add_attrs - Add default attributes for this bus.
include/linux/device.h +2 -0
@@ -68,6 +68,8 @@ extern void bus_unregister(struct bus_type * bus);extern int __must_check bus_rescan_devices (struct bus_type * bus); +extern struct bus_type *find_bus (char *name); +/* iterator helpers for buses */ int bus_for_each_dev(struct bus_type * bus, struct device * start, void * data,
Signature · 1 line
1.5.1.1-dirty
PATCH 7/7 ds2760 W1 slave
In reply to Anton VorontsovThis is W1 slave for ds2760 chip, found inside almost every HP iPaq and HTC PDAs/phones.
--- drivers/w1/slaves/Kconfig | 13 ++++ drivers/w1/slaves/Makefile | 1 + drivers/w1/slaves/w1_ds2760.c | 125 +++++++++++++++++++++++++++++++++++++++++ drivers/w1/slaves/w1_ds2760.h | 50 ++++++++++++++++ drivers/w1/w1_family.h | 1 + 5 files changed, 190 insertions(+), 0 deletions(-) create mode 100644 drivers/w1/slaves/w1_ds2760.c create mode 100644 drivers/w1/slaves/w1_ds2760.h
drivers/w1/slaves/Kconfig +13 -0
@@ -35,4 +35,17 @@ config W1_SLAVE_DS2433_CRC Each block has 30 bytes of data and a two byte CRC16. Full block writes are only allowed if the CRC is valid. +config W1_SLAVE_DS2760 + tristate "Dallas 2760 battery monitor chip (HP iPAQ & others)" + depends on W1 + help + If you enable this you will have the DS2760 battery monitor + chip support. + + The battery monitor chip is used in many batteries/devices + as the one who is responsible for charging/discharging/monitoring + Li+ batteries. + + If you are unsure, say N. + endmenu
drivers/w1/slaves/Makefile +1 -0
@@ -5,4 +5,5 @@ obj-$(CONFIG_W1_SLAVE_THERM) += w1_therm.o obj-$(CONFIG_W1_SLAVE_SMEM) += w1_smem.o obj-$(CONFIG_W1_SLAVE_DS2433) += w1_ds2433.o +obj-$(CONFIG_W1_SLAVE_DS2760) += w1_ds2760.o
drivers/w1/slaves/w1_ds2760.c new file +125 -0
125 lines not on this page · raw message
drivers/w1/slaves/w1_ds2760.h new file +50 -0
50 lines not on this page · raw message
drivers/w1/w1_family.h +1 -0
@@ -33,6 +33,7 @@#define W1_THERM_DS1822 0x22#define W1_EEPROM_DS2433 0x23#define W1_THERM_DS18B20 0x28 +#define W1_FAMILY_DS2760 0x30#define MAXNAMELEN 32
Signature · 1 line
1.5.1.1-dirty
Quoted 2 lines · On Wed, 25 Apr 2007 19:48:20 +0400 Anton Vorontsov <[email protected]> wrote:
Andrew, would you please merge these patches into -mm? They're against today's Linus git tree.
Not for a while, sorry. We already have enough material queued for 2.6.22 and a lot of it is broken. So I am concentrating on fixing the remaining bugs in 2.6.21 and getting some of the new bugs we have prepared for 2.6.22 fixed up.
Meanwhile, I expect lots of new stuff is appearing in the subsystem trees, but there isn't much I can do about that.
Quoted 9 lines · Andrew Morton
Quoted 2 lines · On Wed, 25 Apr 2007 19:48:20 +0400 Anton Vorontsov <[email protected]> wrote:
Andrew, would you please merge these patches into -mm? They're against today's Linus git tree.
Not for a while, sorry. We already have enough material queued for 2.6.22 and a lot of it is broken. So I am concentrating on fixing the remaining bugs in 2.6.21 and getting some of the new bugs we have prepared for 2.6.22 fixed up.
Pity. Not trying to insist too hard, but this battery stuff can not break anything pre-existing in kernel. Also it's proven to work at least on five different embedded devices PXA2xx and S3C (HP iPaqs h2200, rx3000, h5550 and hx4700), with two battery types. Plus I believe that this battery class more than suitable for OLPC guys (battery-2.6 tree).
Anyway, maybe it's even better if we'll boil battery stuff a *bit* more.
Also you didn't [directly] answered how long exactly we should wait, should we come back after 2.6.21 or 2.6.22 release? In later case it's a bit too long, isn't it?
Quoted 2 lines
Meanwhile, I expect lots of new stuff is appearing in the subsystem trees, but there isn't much I can do about that.
:-) You can sum "ADC chips subsystem" to expectations, we're at handhelds.org, going to cleanup and present it in few weeks. It will include Analog-to-Digital chips subsystem, generic ADC battery driver, generic ADC touchscreen driver with debouncing ability, along with few ADC chip drivers.
Thanks,
Signature · 4 lines
Anton Vorontsov email: [email protected] backup email: [email protected] irc://irc.freenode.org/bd2
Quoted 11 lines · Anton Vorontsov
Quoted 9 lines · Andrew Morton
Quoted 2 lines · On Wed, 25 Apr 2007 19:48:20 +0400 Anton Vorontsov <[email protected]> wrote:
Andrew, would you please merge these patches into -mm? They're against today's Linus git tree.
Not for a while, sorry. We already have enough material queued for 2.6.22 and a lot of it is broken. So I am concentrating on fixing the remaining bugs in 2.6.21 and getting some of the new bugs we have prepared for 2.6.22 fixed up.
Quoted 4 lines
Pity. Not trying to insist too hard, but this battery stuff can not break anything pre-existing in kernel. Also it's proven to work at least on five different embedded devices PXA2xx and S3C (HP iPaqs h2200, rx3000, h5550 and hx4700), with two battery types. Plus I believe that this battery
Forgot h4000. Now there are five. ;-)
Signature · 4 lines
Anton Vorontsov email: [email protected] backup email: [email protected] irc://irc.freenode.org/bd2
Quoted 6 lines · On Thu, 26 Apr 2007 01:05:16 +0400 Anton Vorontsov <[email protected]> wrote:
Quoted 5 lines · Andrew Morton
Quoted 2 lines · On Wed, 25 Apr 2007 19:48:20 +0400 Anton Vorontsov <[email protected]> wrote:
Andrew, would you please merge these patches into -mm? They're against today's Linus git tree.
Quoted 7 lines
Quoted 4 lines
Not for a while, sorry. We already have enough material queued for 2.6.22 and a lot of it is broken. So I am concentrating on fixing the remaining bugs in 2.6.21 and getting some of the new bugs we have prepared for 2.6.22 fixed up.
Pity. Not trying to insist too hard, but this battery stuff can not break anything pre-existing in kernel.
That helps.
Quoted 10 lines
Also it's proven to work at least on five
different embedded devices PXA2xx and S3C (HP iPaqs h2200, rx3000, h5550 and hx4700), with two battery types. Plus I believe that this battery class more than suitable for OLPC guys (battery-2.6 tree).Anyway, maybe it's even better if we'll boil battery stuff a *bit* more.
Also you didn't [directly] answered how long exactly we should wait, should we come back after 2.6.21 or 2.6.22 release? In later case it's a bit too long, isn't it?
I'm not sure yet. I've saved away these patches. They seemed to get a decent review - let's aim for 2.6.22.