Skip to contentSkip to conversation

gitweb: Fix few 'use of undefined value' warnings

PATCH In review Petr Baudis 2 participants 5 messages Jun 15, 2016

lore
Share & tools
lore

Petr Baudis

author
#0 lore raw

PATCH 1/1 gitweb: Fix few 'use of undefined value' warnings

Signed-off-by Petr Baudis <[email protected]>

---

 gitweb/gitweb.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
gitweb/gitweb.perl +3 -0
index b67ce41..b51103e 100755
@@ -1038,6 +1038,7 @@ sub git_get_hash_by_path {
 		or die_error(undef, "Open git-ls-tree failed");
 	my $line = <$fd>;
 	close $fd or return undef;
+	$line or return undef;
 
 	#'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa	panic.c'
 	$line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40})\t/;

@@ -1057,6 +1058,7 @@ sub git_get_project_description {
 	open my $fd, "$projectroot/$path/description" or return undef;
 	my $descr = <$fd>;
 	close $fd;
+	$descr or return undef;
 	chomp $descr;
 	return $descr;
 }

@@ -1208,6 +1210,7 @@ sub git_get_last_activity {
 	     'refs/heads') or return;
 	my $most_recent = <$fd>;
 	close $fd or return;
+	$most_recent or return;
 	if ($most_recent =~ / (\d+) [-+][01]\d\d\d$/) {
 		my $timestamp = $1;
 		my $age = time - $timestamp;
author
#2 lore raw
In reply to Petr Baudis

gitweb/gitweb.perl sub git_get_project_description { · line 1064

Quoted 12 lines · Petr Baudis
gitweb/gitweb.perl +1 -0
index b67ce41..b51103e 100755
@@ -1057,6 +1058,7 @@ sub git_get_project_description {
 	open my $fd, "$projectroot/$path/description" or return undef;
 	my $descr = <$fd>;
 	close $fd;
+	$descr or return undef;
 	chomp $descr;
 	return $descr;
 }

It looks like this hunk has been skipped...?

Signature · 4 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett
#3 lore raw
Quoted 15 lines · Petr Baudis

gitweb/gitweb.perl sub git_get_project_description { · line 1064

Quoted 12 lines · Petr Baudis
gitweb/gitweb.perl +1 -0
index b67ce41..b51103e 100755
@@ -1057,6 +1058,7 @@ sub git_get_project_description {
 	open my $fd, "$projectroot/$path/description" or return undef;
 	my $descr = <$fd>;
 	close $fd;
+	$descr or return undef;
 	chomp $descr;
 	return $descr;
 }

It looks like this hunk has been skipped...?

It is more like the whole messages was missed, and then 198a2a8a and others tried to do the same thing but missed this one.

author
#4 lore raw
Quoted 18 lines · Junio C Hamano
Quoted 15 lines · Petr Baudis

gitweb/gitweb.perl sub git_get_project_description { · line 1064

Quoted 12 lines · Petr Baudis
gitweb/gitweb.perl +1 -0
index b67ce41..b51103e 100755
@@ -1057,6 +1058,7 @@ sub git_get_project_description {
 	open my $fd, "$projectroot/$path/description" or return undef;
 	my $descr = <$fd>;
 	close $fd;
+	$descr or return undef;
 	chomp $descr;
 	return $descr;
 }

It looks like this hunk has been skipped...?

Quoted 2 lines

It is more like the whole messages was missed, and then 198a2a8a and others tried to do the same thing but missed this one.

Oh, aha - I thought that it was applied when you replied "thanks"...

Signature · 4 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett