Skip to contentSkip to conversation

Warning fix

PATCH In review WANG Cong 2 participants 2 messages May 3, 2007

Subsystems (2)
USB Sis USB2VGA driver
lore
Share & tools
lore

WANG Cong

author
#0 lore raw

PATCH 1/1 Warning fix

Fix this warning:
drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from incompatible pointer type

Signed-off-by WANG Cong <[email protected]>

---

Compiling test past.;)

drivers/usb/misc/sisusbvga/sisusb_con.c renamed from drivers/usb/misc/sisusbvga/sisusb_con.c.orig +2 -1
@@ -321,9 +321,10 @@ sisusbcon_deinit(struct vc_data *c)
 /* interface routine */
 static u8
 sisusbcon_build_attr(struct vc_data *c, u8 color, u8 intensity,
-			    u8 blink, u8 underline, u8 reverse)
+			    u8 blink, u8 underline, u8 reverse, u8 unused)
 {
 	u8 attr = color;
+	(void) unused;
 
 	if (underline)
 		attr = (attr & 0xf0) | c->vc_ulcolor;
#1 lore raw
Quoted 10 lines · On Thu, 3 May 2007 13:34:29 +0800 WANG Cong <[email protected]> wrote:

Fix this warning:
drivers/usb/misc/sisusbvga/sisusb_con.c:1436: warning: initialization from incompatible pointer type

Signed-off-by WANG Cong <[email protected]>

---

Compiling test past.;)

Thanks.

drivers/usb/misc/sisusbvga/sisusb_con.c sisusbcon_deinit(struct vc_data *c) · line 327

Quoted 11 lines
drivers/usb/misc/sisusbvga/sisusb_con.c renamed from drivers/usb/misc/sisusbvga/sisusb_con.c.orig +2 -1
@@ -321,9 +321,10 @@ sisusbcon_deinit(struct vc_data *c)
 /* interface routine */
 static u8
 sisusbcon_build_attr(struct vc_data *c, u8 color, u8 intensity,
-			    u8 blink, u8 underline, u8 reverse)
+			    u8 blink, u8 underline, u8 reverse, u8 unused)
 {
 	u8 attr = color;
+	(void) unused;

This part isn't needed and we don't usually do it - the compiler will not warn about the unused arg.