build system: no module target ending with slash?
Hi James, hi everybody,
playing with iwlwifi I try to patch it into the kernel and to build it from there. But I have a problem with the build system.
The file drivers/net/wireless/mac80211/Makefile contains one single line:
obj-$(CONFIG_IWLWIFI) += iwlwifi/
When CONFIG_IWLWIFI=m in scripts/Makefile.lib line 29 the target is filtered as it ends with a slash. That results in drivers/net/wireless/mac80211/built-in.o not being built and the build process breaks with an error. What is the correct way to handle this? Why are targets ending with a slash filtered?
Signature · 2 lines
Regards, Chris
Quoted 7 lines · Christian Hesse
Hi James, hi everybody,
playing with iwlwifi I try to patch it into the kernel and to build it from there. But I have a problem with the build system.
The file
drivers/net/wireless/mac80211/Makefilecontains one single line:
Quoted 7 lines
obj-$(CONFIG_IWLWIFI) += iwlwifi/
When
CONFIG_IWLWIFI=minscripts/Makefile.libline 29 the target is filtered as it ends with a slash. That results indrivers/net/wireless/mac80211/built-in.onot being built and the build process breaks with an error. What is the correct way to handle this? Why are targets ending with a slash filtered?
Looks buggy. I will take a look tonight.
Sam
Quoted 10 lines · Sam Ravnborg
Quoted 9 lines · Christian Hesse
Hi James, hi everybody,
playing with iwlwifi I try to patch it into the kernel and to build it from there. But I have a problem with the build system.
The file
drivers/net/wireless/mac80211/Makefilecontains one single line:obj-$(CONFIG_IWLWIFI) += iwlwifi/
Quoted 7 lines
Quoted 5 lines
When
CONFIG_IWLWIFI=minscripts/Makefile.libline 29 the target is filtered as it ends with a slash. That results indrivers/net/wireless/mac80211/built-in.onot being built and the build process breaks with an error. What is the correct way to handle this? Why are targets ending with a slash filtered?Looks buggy. I will take a look tonight.
After some coffee...
Line 29 in Kbuild.include find all modules and a directory is not a module. In line 26 in same file the directory iwlwifi is included in the list of directories to visit.
So there is something else going on.
Anywhere I can get access to the combined source or could you try to post the full Makefile.
Sam
Quoted 18 lines · Sam Ravnborg
Quoted 17 lines · Sam Ravnborg
Quoted 15 lines · Christian Hesse
Hi James, hi everybody,
playing with iwlwifi I try to patch it into the kernel and to build it from there. But I have a problem with the build system.
The file
drivers/net/wireless/mac80211/Makefilecontains one single line:obj-$(CONFIG_IWLWIFI) += iwlwifi/
When
CONFIG_IWLWIFI=minscripts/Makefile.libline 29 the target is filtered as it ends with a slash. That results indrivers/net/wireless/mac80211/built-in.onot being built and the build process breaks with an error. What is the correct way to handle this? Why are targets ending with a slash filtered?
Quoted 8 lines
Quoted 1 line
Looks buggy. I will take a look tonight.
After some coffee...
Line 29 in Kbuild.include find all modules and a directory is not a module. In line 26 in same file the directory iwlwifi is included in the list of directories to visit.
So there is something else going on.
In scripts/Kbuild.include line 26 is empty and line 29 is a comment... Do I look at the wrong place?
I still believe in my version: built-in.o is built if any of $(obj-y) $(obj-m) $(obj-n) $(obj-) $(lib-target) contains anything in scripts/Makefile.build line 77. As scripts/Makefile.lib line 29 filters the only target the object file is not built.
Quoted 2 lines
Anywhere I can get access to the combined source or could you try to post the full
Makefile.
I just generated a patch [0] against vanilla 2.6.21 with latest mac80211 and iwlwifi from git. Get my config [1] and you should get my error.
[0] http://www.eworm.de/tmp/iwlwifi.patch.bz2
[1] http://www.eworm.de/tmp/config-iwlwifi-2.6.21
Signature · 2 lines
Regards, Chris
Quoted 23 lines · Christian Hesse
Quoted 22 lines · Sam Ravnborg
Quoted 11 lines · Sam Ravnborg
Quoted 10 lines · Christian Hesse
Hi James, hi everybody,
playing with iwlwifi I try to patch it into the kernel and to build it from there. But I have a problem with the build system.
The file
drivers/net/wireless/mac80211/Makefilecontains one single line:obj-$(CONFIG_IWLWIFI) += iwlwifi/
Quoted 7 lines
Quoted 5 lines
When
CONFIG_IWLWIFI=minscripts/Makefile.libline 29 the target is filtered as it ends with a slash. That results indrivers/net/wireless/mac80211/built-in.onot being built and the build process breaks with an error. What is the correct way to handle this? Why are targets ending with a slash filtered?Looks buggy. I will take a look tonight.
After some coffee...
Quoted 7 lines
Quoted 4 lines
Line 29 in Kbuild.include find all modules and a directory is not a module. In line 26 in same file the directory iwlwifi is included in the list of directories to visit.
So there is something else going on.In
scripts/Kbuild.includeline 26 is empty and line 29 is a comment... Do I look at the wrong place?
I looked at lxr.linux.no - so probarly an outdated version.
Quoted 5 lines
I still believe in my version: built-in.o is built if any of $(obj-y) $(obj-m) $(obj-n) $(obj-) $(lib-target) contains anything in
scripts/Makefile.buildline 77. Asscripts/Makefile.libline 29 filters the only target the object file is not built.
I have applied your patch and tried it out.
The reason for the problem is the placeholder directory mac80211. kbuild will not waste time building built-in.o for a directory where it is not necessary. So for mac80211 no built-in.o is created since there is no need. The only reference is to a module.
The quick-and-dirty workaround is to add a single
obj-n := xx
in mac80211/Makefile and kbuild is happy again.
I could teach kbuild to create built-in.o also in the case
where we refer to a subdirectory only. But then we would end up with a built-in.o in all directories where we have a kbuild MAkefile (almost) and that is not desireable.
So I recommend the proposed workaround for now with a proper comment.
Sam
Quoted 39 lines · Sam Ravnborg
Quoted 23 lines · Christian Hesse
Quoted 22 lines · Sam Ravnborg
Quoted 11 lines · Sam Ravnborg
Quoted 10 lines · Christian Hesse
Hi James, hi everybody,
playing with iwlwifi I try to patch it into the kernel and to build it from there. But I have a problem with the build system.
The file
drivers/net/wireless/mac80211/Makefilecontains one single line:obj-$(CONFIG_IWLWIFI) += iwlwifi/
Quoted 7 lines
Quoted 5 lines
When
CONFIG_IWLWIFI=minscripts/Makefile.libline 29 the target is filtered as it ends with a slash. That results indrivers/net/wireless/mac80211/built-in.onot being built and the build process breaks with an error. What is the correct way to handle this? Why are targets ending with a slash filtered?Looks buggy. I will take a look tonight.
After some coffee...
Quoted 7 lines
Quoted 4 lines
Line 29 in Kbuild.include find all modules and a directory is not a module. In line 26 in same file the directory iwlwifi is included in the list of directories to visit.
So there is something else going on.In
scripts/Kbuild.includeline 26 is empty and line 29 is a comment... Do I look at the wrong place?I looked at lxr.linux.no - so probarly an outdated version.
Quoted 4 lines
I still believe in my version: built-in.o is built if any of $(obj-y) $(obj-m) $(obj-n) $(obj-) $(lib-target) contains anything in
scripts/Makefile.buildline 77. Asscripts/Makefile.libline 29 filters the only target the object file is not built.
Quoted 5 lines
I have applied your patch and tried it out.
The reason for the problem is the placeholder directory mac80211. kbuild will not waste time building built-in.o for a directory where it is not necessary. So for mac80211 no built-in.o is created since there is no need. The only reference is to a module.
Agreed that it is not really needed. But if you don't build it you should not try to link it later...
Quoted 8 lines
The quick-and-dirty workaround is to add a single
obj-n := xx
in mac80211/Makefile and kbuild is happy again.I could teach kbuild to create built-in.o also in the case where we refer to a subdirectory only. But then we would end up with a built-in.o in all directories where we have a kbuild MAkefile (almost) and that is not desireable.
I would prefer to teach it not to link object files that are not built.
Quoted 1 line
So I recommend the proposed workaround for now with a proper comment.
Ok, thanks for your help.
Signature · 2 lines
Regards, Chris
Quoted 7 lines · Christian Hesse
Agreed that it is not really needed. But if you don't build it you should not try to link it later...
Quoted 4 lines
The quick-and-dirty workaround is to add a single
obj-n := xx
in mac80211/Makefile and kbuild is happy again.
Quoted 6 lines
Quoted 4 lines
I could teach kbuild to create built-in.o also in the case where we refer to a subdirectory only. But then we would end up with a built-in.o in all directories where we have a kbuild MAkefile (almost) and that is not desireable.
I would prefer to teach it not to link object files that are not built.
But you already _told_ kbuild that mac80211/ would contain a built-in.o using following statement in drivers/net/wireless/Makefile:
obj-y += mac80211/
Changing this to obj-$(CONFIG_IWLWIFI) += mac80211/ would give kbuild the _correct_ info.
obj-m += dir/
tell kbuild this directory contains a module so it will descend and build obj-y += dir/
tall kbuild that directory contains stuff to be built-in and _maybe_ a module so it will descend and build.
Note that when kbuild has entered a subdirectory it has lost knowledge of _how_ it came there so if you have lied to kbuild it will not detect it. So in your case you told kbuild that there is stuff to be build in in the mac80211/ dir which was incorrect.
Sam