PATCH: free mm if spufs_fill_dir() failed
Subsystems (3)
In case spufs_fill_dir() fails only put_spu_context() gets called for cleanup and the acquired mm_struct never gets freed.
Signed-off-by Sebastian Siewior <[email protected]>
arch/powerpc/platforms/cell/spufs/inode.c +1 -0
@@ -277,6 +277,7 @@ spufs_mkdir(struct inode *dir, struct de goto out; out_free_ctx: +spu_forget (ctx);put_spu_context (ctx); out_iput:iput (inode);
Sebastian,
Quoted 2 lines
In case
spufs_fill_dir()fails onlyput_spu_context()gets called for cleanup and the acquiredmm_structnever gets freed.
Good catch. However - could we do the mmput in the context destroy path instead?
Also, you're probably better-off sending patches inline. It makes commenting on the patch much easier for some mailers.
Cheers,
Jeremy