Skip to contentSkip to conversation

Fix warning when building fs/afs/super.c

PATCH New Tony Breeds 1 participant 1 message May 11, 2007 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix warning when building fs/afs/super.c

Fix build waning in fs/afs/super.c

fs/afs/super.c: In function 'afs_parse_options':
fs/afs/super.c:153: warning: passing argument 2 of 'match_token' discards qualifiers from pointer target type

AFS declares it's match_table as const, which is discrded in lib/parser.c. match_token() doesn't modify the table so making it const should be safe.

---
 include/linux/parser.h |    2 +-
 lib/parser.c           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/parser.h +1 -1
Index: working/include/linux/parser.h
===================================================================
@@ -25,7 +25,7 @@ typedef struct {
 	char *to;
 } substring_t;
 
-int match_token(char *, match_table_t table, substring_t args[]);
+int match_token(char *, const match_table_t table, substring_t args[]);
 int match_int(substring_t *, int *result);
 int match_octal(substring_t *, int *result);
 int match_hex(substring_t *, int *result);
lib/parser.c +1 -1
Index: working/lib/parser.c
===================================================================
@@ -100,7 +100,7 @@ static int match_one(char *s, const char
  * format identifiers which will be taken into account when matching the
  * tokens, and whose locations will be returned in the @args array.
  */
-int match_token(char *s, match_table_t table, substring_t args[])
+int match_token(char *s, const match_table_t table, substring_t args[])
 {
 	const struct match_token *p;
 

Yours Tony

linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!