Skip to contentSkip to conversation

IPMI: fix SI address space settings

PATCH In review Corey Minyard 2 participants 3 messages May 11, 2007 IPMI

lore
Share & tools
lore

Corey Minyard

author
#0 lore raw

PATCH 1/1 IPMI: fix SI address space settings

From: Corey Minyard <[email protected]>
Fix a rather obvious error that Patrick found in the setup routines. Need to set the proper address space in the ACPI case.

Signed-off-by Corey Minyard <[email protected]>
Cc Patrick Schoeller <[email protected]>
drivers/char/ipmi/ipmi_si_intf.c +2 -2
Index: linux-2.6.21/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
@@ -1915,10 +1915,10 @@ static __devinit int try_init_acpi(struc
 
 	if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) {
 		info->io_setup = mem_setup;
-		info->io.addr_type = IPMI_IO_ADDR_SPACE;
+		info->io.addr_type = IPMI_MEM_ADDR_SPACE;
 	} else if (spmi->addr.space_id == ACPI_ADR_SPACE_SYSTEM_IO) {
 		info->io_setup = port_setup;
-		info->io.addr_type = IPMI_MEM_ADDR_SPACE;
+		info->io.addr_type = IPMI_IO_ADDR_SPACE;
 	} else {
 		kfree(info);
 		printk("ipmi_si: Unknown ACPI I/O Address type\n");
#1 lore raw
Quoted 2 lines · On Fri, 11 May 2007 07:56:16 -0500 Corey Minyard <[email protected]> wrote:

Fix a rather obvious error that Patrick found in the setup routines. Need to set the proper address space in the ACPI case.

I have assumed that both these fixes are desired in 2.6.21.x.

In general, it helps if people can think about that and express an explicit opinion when sending fixes, please.

author
#2 lore raw
Quoted 10 lines · Andrew Morton
Quoted 3 lines · On Fri, 11 May 2007 07:56:16 -0500 Corey Minyard <[email protected]> wrote:

Fix a rather obvious error that Patrick found in the setup routines. Need to set the proper address space in the ACPI case.

I have assumed that both these fixes are desired in 2.6.21.x.

The ACPI fix can go to 2.6.21.x.

The PPC openfirmware one is a fix for a patch that just went in for 2.6.22. So that one doesn't need to be put in 2.6.21.x.

Quoted 3 lines

In general, it helps if people can think about that and express an explicit opinion when sending fixes, please.

Will do. Thanks.

-corey