Skip to contentSkip to conversation

spidernet: remove unnecessary accesses to phy

PATCH Applied Linas Vepstas 2 participants 5 messages May 10, 2007 – May 12, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Linas Vepstas

author
#0 lore raw

PATCH 1/1 spidernet: remove unnecessary accesses to phy

Jeff, please apply for 2.6.22; This is a purely janitorial patch.

(I will have additonal patches for the spidernet in a few days; I'm still debugging a rather nasty hang.)

--linas

From: Ishizaki Kou <[email protected]>

This patch removes unnecessary accesses to phy registers.

Signed-off-by Kou Ishizaki <[email protected]>
Signed-off-by Linas Vepstas <[email protected]>

----

 drivers/net/spider_net.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/net/spider_net.c +3 -5
Index: linux-2.6.21-rc7-mm2/drivers/net/spider_net.c
===================================================================
@@ -175,12 +175,10 @@ spider_net_setup_aneg(struct spider_net_
 {
 	struct mii_phy *phy = &card->phy;
 	u32 advertise = 0;
-	u16 bmcr, bmsr, stat1000, estat;
+	u16 bmsr, estat;
 
-	bmcr     = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMCR);
-	bmsr     = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMSR);
-	stat1000 = spider_net_read_phy(card->netdev, phy->mii_id, MII_STAT1000);
-	estat    = spider_net_read_phy(card->netdev, phy->mii_id, MII_ESTATUS);
+	bmsr  = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMSR);
+	estat = spider_net_read_phy(card->netdev, phy->mii_id, MII_ESTATUS);
 
 	if (bmsr & BMSR_10HALF)
 		advertise |= ADVERTISED_10baseT_Half;
Applied
#1 lore raw
Quoted 11 lines · Linas Vepstas

Jeff, please apply for 2.6.22; This is a purely janitorial patch.

(I will have additonal patches for the spidernet in a few days; I'm still debugging a rather nasty hang.)

--linas

From: Ishizaki Kou <[email protected]>

Quoted 8 lines

This patch removes unnecessary accesses to phy registers.

Signed-off-by Kou Ishizaki <[email protected]>
Signed-off-by Linas Vepstas <[email protected]>

----

 drivers/net/spider_net.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

applied. Please move comments that do not belong in the permanent record BELOW the "---". See Documentation/SubmittingPatches for more info.

Jeff

author
#2 lore raw
Quoted 2 lines · Jeff Garzik

applied.

Thanks.

Quoted 2 lines

Please move comments that do not belong in the permanent
record BELOW the "---". See Documentation/SubmittingPatches for more info.

oops, sorry.

--linas

I've also got a multi-month old s2io patch that's in limbo. It was ack'ed by an s2io maintainer, but otherwise fell through the cracks. If you can find it and apply it, great, otherwise I'll resubmit "real soon now".

--linas

#3 lore raw
Quoted 7 lines · Linas Vepstas
Quoted 1 line · Jeff Garzik

applied.

Thanks.

Quoted 1 line

Please move comments that do not belong in the permanent record BELOW the "---". See Documentation/SubmittingPatches for more info.

Quoted 7 lines

oops, sorry.

--linas

I've also got a multi-month old s2io patch that's in limbo. It was ack'ed by an s2io maintainer, but otherwise fell through the cracks. If you can find it and apply it, great, otherwise I'll resubmit "real soon now".

If you don't hear about a patch in over 14 days, you may assume I've deleted it from my mbox queue.

Jeff

author
#4 lore raw
Quoted 9 lines · Jeff Garzik
Quoted 5 lines · Linas Vepstas

I've also got a multi-month old s2io patch that's in limbo. It was ack'ed by an s2io maintainer, but otherwise fell through the cracks. If you can find it and apply it, great, otherwise I'll resubmit "real soon now".

If you don't hear about a patch in over 14 days, you may assume I've deleted it from my mbox queue.

Next week then. yow! I don't have enough disk space for all this stuff...

--linas