Skip to contentSkip to conversation

pxamci.c fails to compile

PATCH Mike Rapoport 3 participants 3 messages May 14, 2007 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

The PXA MMC controller does not compile for PXA27x after MMC reorganization, because it uses protocol defines to implement HW erratum workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ). The following patch fixes it

Signature · 2 lines
Sincerely yours,
Mike.
drivers/mmc/host/pxamci.c +1 -0
index d97d386..00fc99f 100644
@@ -24,6 +24,7 @@
 #include <linux/interrupt.h>
 #include <linux/dma-mapping.h>
 #include <linux/mmc/host.h>
+#include <linux/mmc/mmc.h>
 
 #include <asm/dma.h>
 #include <asm/io.h>
#1 lore raw
Quoted 4 lines · Mike Rapoport

The PXA MMC controller does not compile for PXA27x after MMC reorganization, because it uses protocol defines to implement HW erratum workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ). The following patch fixes it

It's been discussed over the last few days, and the conclusion that has been reached is that the work-around is in fact itself buggy. The real fix should be merged soon.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#2 lore raw
Quoted 10 lines · Russell King
Quoted 4 lines · Mike Rapoport

The PXA MMC controller does not compile for PXA27x after MMC reorganization, because it uses protocol defines to implement HW erratum workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ). The following patch fixes it

It's been discussed over the last few days, and the conclusion that has been reached is that the work-around is in fact itself buggy. The real fix should be merged soon.

Indeed. I have the fix ready to go. I was hoping I could get some fix for at91 aswell, but that doesn't seem to be happening so I'll push in a bit.

Rgds

Signature · 5 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org